Skip to content

Spell out review-within-two-weeks rule for Code Owners #3272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2018

Conversation

tautschnig
Copy link
Collaborator

Pull requests that do not receive timely feedback block progress and cause
unnecessary overhead as repeated rebasing is necessary and increasingly costly.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Pull requests that do not receive timely feedback block progress and cause
unnecessary overhead as repeated rebasing is necessary and increasingly costly.
@tautschnig tautschnig merged commit d1733d8 into diffblue:develop Nov 5, 2018
@tautschnig tautschnig deleted the two-weeks branch November 5, 2018 16:45
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: fe06991).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90297063

@martin-cs
Copy link
Collaborator

I don't suppose anyone feels like writing some kind of kick script to enforce this do they?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants