Remove unused ID_free and related methods #3141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
requested review from
chrisr-diffblue,
martin-cs and
peterschrammel
as code owners
allredj
reviewed
Oct 11, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: acc15f6).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87651924
martin-cs
reviewed
Oct 11, 2018
tautschnig
approved these changes
Oct 11, 2018
There was a problem hiding this comment.
I'm with @martin-cs: can we please kill any use of ID_free? I don't mind whether done in this PR or a follow-up one and thus approving. Maybe @kroening can confirm that this is the way to go?
It appears to be impossible to create a free statement (as opposed to a call to stdlib's free); therefore these paths cannot be exercised.
smowton
force-pushed
the
smowton/cleanup/value-set-free
branch
from
acc15f6 to
35cfbb8
Compare
|
Updated; @kroening can you confirm if this is ok? Is there perhaps a secret out-of-tree user that creates a codet with statement == "free"? |
smowton
changed the title
allredj
reviewed
Oct 12, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 35cfbb8).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87744962
owen-mc-diffblue
approved these changes
Oct 12, 2018
peterschrammel
approved these changes
Oct 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears to be impossible to create a free statement (as opposed to a call to stdlib's free); therefore this path can't be exercised. All the better, since updating everyone's pointers (rather than tracking allocated / deallocated status with the object itself) is surely a mistake in any case.
Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).My commit message includes data points confirming performance improvements (if claimed).White-space or formatting changes outside the feature-related changed lines are in commits of their own.