cleanup accesses to subtype() and subtypes() #2991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kroening
commented
Sep 19, 2018
kroening
commented
- Each commit message has a non-empty body, explaining why the change was made.
- My contribution is formatted in line with CODING_STANDARD.md.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- White-space or formatting changes outside the feature-related changed lines are in commits of their own.
kroening
requested review from
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
tautschnig
requested changes
Sep 19, 2018
src/util/type.h
Outdated
| @@ -141,6 +141,18 @@ class type_with_subtypet:public typet | |||
| #endif | |||
| }; | |||
|
|
|||
| const type_with_subtypet &to_type_with_subtype(const typet &type) | |||
There was a problem hiding this comment.
Here and all other newly introduced functions here: missing inline
|
Also needs a rebase on current develop to make CI pass. |
kroening
force-pushed
the
type-cleanup
branch
from
78e7f0b to
20c4109
Compare
tautschnig
approved these changes
Sep 19, 2018
kroening
force-pushed
the
type-cleanup
branch
from
20c4109 to
3f9c289
Compare
kroening
requested review from
chrisr-diffblue,
martin-cs and
thk123
as code owners
kroening
force-pushed
the
type-cleanup
branch
3 times, most recently
from
acae9ec to
b64a22e
Compare
kroening
force-pushed
the
type-cleanup
branch
2 times, most recently
from
2898cd3 to
02a1b95
Compare
allredj
reviewed
Sep 20, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 02a1b95).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85397997
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.