-
Notifications
You must be signed in to change notification settings - Fork 277
only do bitvector analysis when used #2893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It would still be nice if such changes came with data, e.g., "before, doing X took N seconds; now this returns in M<N seconds." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR failed Diffblue compatibility checks (cbmc commit: cae4f30).
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
Say goto-instrument --count-eloc on a larger goto-binary (with 10k ELOCs) is now 0.4s vs. 5.1s before. |
Thanks - that's the sort of information I would expect to be included in commit messages by default. It's data that is trivial to gather while working on it, but a lot more effort to collect later on. |
cae4f30
to
6a94dfb
Compare
ok, done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR failed Diffblue compatibility checks (cbmc commit: 6a94dfb).
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
Rationale: goto-instrument --count-eloc on a larger goto-binary (with 10k ELOCs) is now 0.4s vs. 5.1s before.
6a94dfb
to
a224e94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR failed Diffblue compatibility checks (cbmc commit: a224e94).
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The bitvector analysis can be expensive in terms of time and memory.
This avoids doing it unless the result is actually used.