Skip to content

only do bitvector analysis when used #2893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2018
Merged

Conversation

kroening
Copy link
Member

@kroening kroening commented Sep 4, 2018

The bitvector analysis can be expensive in terms of time and memory.
This avoids doing it unless the result is actually used.

@tautschnig
Copy link
Collaborator

It would still be nice if such changes came with data, e.g., "before, doing X took N seconds; now this returns in M<N seconds."

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR failed Diffblue compatibility checks (cbmc commit: cae4f30).
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

@kroening
Copy link
Member Author

kroening commented Sep 4, 2018

Say goto-instrument --count-eloc on a larger goto-binary (with 10k ELOCs) is now 0.4s vs. 5.1s before.

@tautschnig
Copy link
Collaborator

Say goto-instrument --count-eloc on a larger goto-binary (with 10k ELOCs) is now 0.4s vs. 5.1s before.

Thanks - that's the sort of information I would expect to be included in commit messages by default. It's data that is trivial to gather while working on it, but a lot more effort to collect later on.

@kroening kroening force-pushed the goto-ckeck-bv-analysis branch from cae4f30 to 6a94dfb Compare September 4, 2018 16:30
@kroening
Copy link
Member Author

kroening commented Sep 4, 2018

ok, done

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR failed Diffblue compatibility checks (cbmc commit: 6a94dfb).
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

Rationale: goto-instrument --count-eloc on a larger goto-binary (with 10k
ELOCs) is now 0.4s vs. 5.1s before.
@kroening kroening force-pushed the goto-ckeck-bv-analysis branch from 6a94dfb to a224e94 Compare September 4, 2018 21:12
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR failed Diffblue compatibility checks (cbmc commit: a224e94).
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

@kroening kroening merged commit 575ff4a into develop Sep 5, 2018
@kroening kroening deleted the goto-ckeck-bv-analysis branch September 5, 2018 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants