simplify how graphml error witnesses are built #2824
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
requested review from
peterschrammel,
pkesseli and
smowton
as code owners
tautschnig
requested changes
Aug 23, 2018
| if(!it->lhs_object_value.is_constant() || | ||
| !it->lhs_object_value.has_operands() || | ||
| !has_prefix(id2string(it->lhs_object_value.op0().get(ID_value)), | ||
| "INVALID-")) |
There was a problem hiding this comment.
This sanity check is now missing.
There was a problem hiding this comment.
Yes, but we haven't been generating these INVALID-OBJECTS for quite a while.
There was a problem hiding this comment.
I trust this is true, but what change was it that made those go away?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might make the witnesses more robust, and will also enable removing lhs_object and lhs_object_value from our traces.