Add get_mutable to const_depth_iteratort #1803
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets a depth_iteratort pointing to the same element as the const_depth_iteratort as long as you can provide a non-const reference to the original root element.
NathanJPhillips
requested review from
kroening,
peterschrammel,
smowton and
tautschnig
as code owners
|
Hmmm. What do you think of the alternative where instead of the const-iterator having an upgrade method, instead the non-const iterator has an alternate constructor where it gets a const reference and a get-nonconst-reference thunk to call when it needs to? |
|
It seems a good idea to me. I'll close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets a depth_iteratort pointing to the same element as the const_depth_iteratort so long as you can provide a non-const reference to the original root element.
It is required for #1789.