Fix typing in signed/unsigned comparison #1039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
reviewed
Jun 19, 2017
src/util/tempfile.cpp
Outdated
| @@ -45,7 +45,7 @@ int my_mkstemps(char *template_str, int suffix_len) | |||
|
|
|||
| std::size_t template_length=strlen(template_str); | |||
|
|
|||
| if(suffix_len+6>template_length) | |||
| if(static_cast<std::size_t>(suffix_len+6)>template_length) | |||
There was a problem hiding this comment.
one could imagine a PRECONDITION(suffix_len>=1) or so.
There was a problem hiding this comment.
I have added a check suffix_len<0 as used by glibc.
tautschnig
force-pushed
the
signed-unsigned
branch
from
be5adbc to
419544e
Compare
tautschnig
force-pushed
the
signed-unsigned
branch
from
419544e to
8542736
Compare
peterschrammel
approved these changes
Jun 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.