Don't think function declarations should have function header comments

Previously we would always checkf for function header comments if we
found a function. Now if we find a ; before a { then we assume it is a
function declaration, otherwise we assume it is a function
implementation and therefore should have the function header comment.

This does mean that functions with bodies in header files are going to
require a function header comment.

Author: thk123

regression/cpp-linter/function-comment-header7/main.cpp

@@ -0,0 +1,15 @@
+/*******************************************************************\
+
+Module: Lint Examples
+
+Author: Thomas Kiley, [email protected]
+
+\*******************************************************************/
+
+
+
+static void fun(
+  bool param1,
+  bool param2);
+
+static void bar();

regression/cpp-linter/function-comment-header7/test.desc

@@ -0,0 +1,7 @@
+CORE
+main.cpp
+
+^Total errors found: 0$
+^EXIT=0$
+^SIGNAL=0$
+--

scripts/cpplint.py

@@ -3120,26 +3120,15 @@ def CheckForFunctionCommentHeaders(filename, raw_lines, error):
         body_found = False
         for start_linenum in xrange(linenum, len(raw_lines)):
           start_line = raw_lines[start_linenum]
-          joined_line += ' ' + start_line.lstrip()
-          if Search(r'(;|})', start_line):  # Declarations and trivial functions
+          if Search(r'{', start_line):
             body_found = True
-            break                              # ... ignore
-          elif Search(r'{', start_line):
-            body_found = True
-            function = Search(r'((\w|:)*)\(', line).group(1)
-            if Match(r'TEST', function):    # Handle TEST... macros
-              parameter_regexp = Search(r'(\(.*\))', joined_line)
-              if parameter_regexp:             # Ignore bad syntax
-                function += parameter_regexp.group(1)
-            else:
-              function += '()'
-            function_state.Begin(function)
             break
-      if not body_found:
-        # No body for the function (or evidence of a non-function) was found.
-        error(filename, linenum, 'readability/fn_size', 5,
-              'Lint failed to find start of function body.')
-      else:
+          elif Search(r';', start_line):
+            body_found = False
+            break
+
+      # body found, i.e. not a declaration
+      if body_found:
         CheckForFunctionCommentHeader(filename, raw_lines, linenum, function_name, error)
     linenum += 1