Add v8 5.7 support. #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perfect! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for v8 5.7.
The only breaking change in the v8 API is the removal of the
resource_is_embedder_debug_scriptargument of theScriptOriginconstructor. It is now ignored when compiled for v8 5.7 and newer.With #15 and #16, this patch should fix the compilation on ArchLinux x86_64 (and on any system that brings recent versions of Clang and v8), and therefore should probably fix #14 as well.
As a bonus, this commit also fixes the generation of lots of warnings related to incorrect casing in the
ffigenerated module.