Skip to content

Update flask to 2.3.3 in order to fix url_encode issue #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Oct 2, 2023

What does this PR do?:

This PR updates the version of flask to 2.3.3 in order to avoid the error:

ImportError: cannot import name 'url_quote' from 'werkzeug.urls'
(/home/tpetkos/github/thepetk/devfile-samples/devfile-sample-python-basic/venv/
lib/python3.10/site-packages/werkzeug/urls.py)

As mentioned in the changelog the 2.3.3 version uses Werkzeug >= 2.3.7.

Notes for the Reviewer

In order to reproduce the error try to install dependencies and run flask inside main branch (I managed to do that with python version 3.10.x:

python3 -m venv venv/
source venv/bin/activate
pip3 install -r requirements.txt
flask run

You can verify that the bug has been fixed by checking out to this branch, try again to run flask.

Signed-off-by: thepetk <[email protected]>
Copy link
Contributor

@elsony elsony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@thepetk thepetk merged commit c4f07d1 into devfile-samples:main Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants