fix(auth)!: correct HTTP status codes for authentication and authorization failures #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation failures BREAKING CHANGE: Authentication failures now return 401 instead of 403 Changes the EnforceAuthMiddleware to follow HTTP RFC 7235 semantics: - Unauthenticated requests (no/invalid token) now return 401 Unauthorized instead of 403 Forbidden - Authorization failures (valid token, insufficient scopes) now return 403 Forbidden instead of 401 Unauthorized This is a breaking change for clients that expect 403 for unauthenticated requests. The correct behavior is: - 401: "Who are you?" - Authentication required/failed - 403: "I know who you are, but you lack permission" - Authorization failed Additional improvements: - Remove sensitive token data from error logs (security fix) - Handle missing JWT scope claim gracefully (prevent KeyError) - Improve error messages for better debugging - Add detailed logging for authorization failures
alukach
force-pushed
the
fix/correct-auth-codes
branch
from
45df0c2 to
4c4a354
Compare
alukach
added a commit
that referenced
this pull request
Dec 15, 2025
🤖 I have created a release *beep* *boop* --- ## [0.11.0](v0.10.1...v0.11.0) (2025-12-15) ### Bug Fixes * **auth:** Authentication failures now return 401 instead of 403 * **auth:** correct HTTP status codes for authentication and authorization failures ([#108](#108)) ([17227e4](17227e4)) * Ensure x-forwarded-port header is used in Forwarded header ([#115](#115)) ([78525b1](78525b1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: ds-release-bot[bot] <116609932+ds-release-bot[bot]@users.noreply.github.com> Co-authored-by: Anthony Lukach <[email protected]>
pantierra
pushed a commit
that referenced
this pull request
Dec 16, 2025
🤖 I have created a release *beep* *boop* --- ## [0.11.0](v0.10.1...v0.11.0) (2025-12-15) ### Bug Fixes * **auth:** Authentication failures now return 401 instead of 403 * **auth:** correct HTTP status codes for authentication and authorization failures ([#108](#108)) ([17227e4](17227e4)) * Ensure x-forwarded-port header is used in Forwarded header ([#115](#115)) ([78525b1](78525b1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: ds-release-bot[bot] <116609932+ds-release-bot[bot]@users.noreply.github.com> Co-authored-by: Anthony Lukach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Authentication failures now return 401 instead of 403
Changes the EnforceAuthMiddleware to follow HTTP RFC 7235 semantics:
This is a breaking change for clients that expect 403 for unauthenticated requests. The correct behavior is:
Additional improvements: