Followup: Handle new Sort.unsorted() sorting strategy
#130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #130 +/- ##
============================================
+ Coverage 59.3% 59.66% +0.35%
- Complexity 513 515 +2
============================================
Files 70 71 +1
Lines 1912 1909 -3
Branches 368 365 -3
============================================
+ Hits 1134 1139 +5
+ Misses 632 629 -3
+ Partials 146 141 -5
Continue to review full report at Codecov.
|
derjust
force-pushed
the
Issue_99
branch
2 times, most recently
from
9a03d51 to
9fc28df
Compare
Spring-Data no longer passes in `null` if no sorting order is given by the caller but uses `Sort.unsorted()` which incorrectly causes an Exception. This should also solve #99 Followup to 8c3e139 Also getting rid of some JDK9 deprecated warnings on the JDK classes - as those methods exist in JDK8 already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spring-Data no longer passes in
nullif no sorting order is given by the caller but usesSort.unsorted()which incorrectly causes an Exception.This should also solve #99
Followup to 8c3e139
Also getting rid of some JDK9 deprecated warnings on the JDK classes - as those methods exist in JDK8 already.