Spring5 #100
Merged
Spring5 #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a first slap at supporting Sprint 5 with Spring-Data Kay-SR1. It mainly fixed the compile errors and made all tests run green again. Also added some syntactical sugar here and there due to increased JDK8 support. Note: Methods might not yet fully support the Sprint5/Spring-Data 2 usage of `Optional` and such.
Spring-Data no longer passes in `null` if no sorting order is given by the caller but uses `Sort.unsorted()` which incorrectly causes an Exception. This should also solve #99
`null` arguments passed into the `find`-methods should not cause a NPE down the road but should be actively rejected. Solves #51
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
============================================
+ Coverage 40.49% 40.92% +0.42%
- Complexity 337 338 +1
============================================
Files 64 64
Lines 1768 1757 -11
Branches 348 344 -4
============================================
+ Hits 716 719 +3
+ Misses 944 927 -17
- Partials 108 111 +3
Continue to review full report at Codecov.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental branch to support Spring5
✅ Unit tests working
✅ Integration tests working
✅ Update AWS DynamoDB SDK
Feel free to pull & build locally to test it out:
mvn install