CE-59 Couchbase Plugin : Conversion of python2 to python3 (#38)

Author: ayesharustgi-delphix

plugin_config.yml

@@ -1,8 +1,8 @@
 id: 18f4ff11-b758-4bf2-9a37-719a22f5a4b8
 name: sc:couchbase
-externalVersion: "1.1.4"
-buildNumber: 1.1.4.0
-language: PYTHON27
+externalVersion: "1.2.0"
+buildNumber: 1.2.0.0
+language: PYTHON38
 hostTypes:
 - UNIX
 pluginType: STAGED

src/controller/couchbase_lib/_bucket.py

@@ -139,7 +139,7 @@ def bucket_list(self, return_type=list):
                 logger.debug("parse json")
                 bucket_list_dict = json.loads(bucket_list)
                 logger.debug("remap json")
-                bucket_list_dict = map(helper_lib.remap_bucket_json, bucket_list_dict)
+                bucket_list_dict = list(map(helper_lib.remap_bucket_json, bucket_list_dict))
         logger.debug("Bucket details in staged environment: {}".format(bucket_list))
         return bucket_list_dict
 
@@ -179,13 +179,13 @@ def monitor_bucket(self, bucket_name, staging_UUID):
         stdout, stderr, exit_code = utilities.execute_bash(self.connection, command, **kwargs)
         logger.debug("stdout: {}".format(stdout))
         content = json.loads(stdout)
-        pending_docs = self._get_last_value_of_node_stats(content["nodeStats"].values()[0])
+        pending_docs = self._get_last_value_of_node_stats(list(content["nodeStats"].values())[0])
         while pending_docs != 0:
             logger.debug("Documents pending for replication: {}".format(pending_docs))
             helper_lib.sleepForSecond(30)
             stdout, stderr, exit_code = utilities.execute_bash(self.connection, command, **kwargs)
             content = json.loads(stdout)
-            pending_docs = self._get_last_value_of_node_stats(content["nodeStats"].values()[0])
+            pending_docs = self._get_last_value_of_node_stats(list(content["nodeStats"].values())[0])
         else:
             logger.debug("Replication for bucket {} completed".format(bucket_name))
 

src/controller/couchbase_lib/_mixin_interface.py

@@ -36,6 +36,6 @@ def inner(*args, **kwargs):
             try:
                 return function(*args, **kwargs)
             except AttributeError as AE:
-                logger.debug("Failed to read value from schema objects. Error: {}".format(AE.message))
+                logger.debug("Failed to read value from schema objects. Error: {}".format(str(AE)))
                 raise
         return inner

src/controller/couchbase_lib/_xdcr.py

@@ -79,7 +79,7 @@ def xdcr_replicate(self, src, tgt):
             logger.debug("{} : XDCR replication create succeeded".format(tgt))
             helper_lib.sleepForSecond(2)
         except Exception as e:
-            logger.debug("XDCR error {}".format(e.message))
+            logger.debug("XDCR error {}".format(str(e)))
 
 
     def get_replication_uuid(self):
@@ -165,7 +165,7 @@ def get_replication_uuid(self):
         except UserError:
             raise
         except Exception as err:
-            logger.warn("Error identified: {} ".format(err.message))
+            logger.warn("Error identified: {} ".format(str(err)))
             logger.warn("UUID is None. Not able to find any cluster")
             return None
 

src/controller/couchbase_operation.py

@@ -117,7 +117,7 @@ def run_couchbase_command(self, couchbase_command, **kwargs):
 
         logger.debug("couchbase command to run: {}".format(command))
         stdout, stderr, exit_code = utilities.execute_bash(self.connection, command, environment_vars=env)
-        return [stdout.encode('utf-8'), stderr.encode('utf-8'), exit_code]
+        return [stdout, stderr, exit_code]
 
 
     def run_os_command(self, os_command, **kwargs):
@@ -131,7 +131,7 @@ def run_os_command(self, os_command, **kwargs):
 
         logger.debug("os command to run: {}".format(command))
         stdout, stderr, exit_code = utilities.execute_bash(self.connection, command)
-        return [stdout.encode('utf-8'), stderr.encode('utf-8'), exit_code]
+        return [stdout, stderr, exit_code]
 
 
     def restart_couchbase(self, provision=False):
@@ -190,9 +190,9 @@ def stop_couchbase(self):
         except Exception as err:
             logger.debug("Exception Error: {}".format(err)) 
             if self.status() == Status.INACTIVE:
-                logger.debug("Seems like couchbase service is not running. {}".format(err.message))
+                logger.debug("Seems like couchbase service is not running. {}".format(str(err)))
             else:
-                raise CouchbaseServicesError(err.message)
+                raise CouchbaseServicesError(str(err))
 
 
     def ip_file_name(self):
@@ -253,7 +253,7 @@ def staging_bootstrap_status(self):
             # TODO
             # rewrite it 
             logger.debug("Exception: {}".format(str(error)))
-            if re.search("Unable to connect to host at", error.message):
+            if re.search("Unable to connect to host at", str(error)):
                 logger.debug("Couchbase service is not running")
             return Status.INACTIVE
 
@@ -339,7 +339,7 @@ def status(self, provision=False):
             # TODO
             # rewrite it 
             logger.debug("Exception: {}".format(str(error)))
-            if re.search("Unable to connect to host at", error.message):
+            if re.search("Unable to connect to host at", str(error)):
                 logger.debug("Couchbase service is not running")
             return Status.INACTIVE
 
@@ -399,6 +399,8 @@ def create_config_dir(self):
         while loop_var:
             bin_directory = os.path.dirname(bin_directory)
             loop_var = loop_var - 1
+        logger.debug(f"bin_directory={bin_directory}")
+        logger.debug(f"DELPHIX_HIDDEN_FOLDER={DELPHIX_HIDDEN_FOLDER}")
         dir_name = bin_directory + "/" + DELPHIX_HIDDEN_FOLDER
         if not helper_lib.check_dir_present(self.connection, dir_name):
             self.make_directory(dir_name, force_env_user=True)
@@ -440,7 +442,7 @@ def source_bucket_list(self):
             bucket_list = bucket_list.replace("False", "\"False\"")
             logger.debug("parse json")
             bucket_list_dict = json.loads(bucket_list)
-            bucket_list_dict = map(helper_lib.remap_bucket_json, bucket_list_dict)
+            bucket_list_dict = list(map(helper_lib.remap_bucket_json, bucket_list_dict))
 
         logger.debug("Source Bucket Information {}".format(bucket_list_dict))
         return bucket_list_dict
@@ -488,7 +490,7 @@ def source_bucket_list_offline(self):
 
         backup_list = bucket_list.split('\n')
         logger.debug("Bucket search output: {}".format(backup_list))
-        date_list = map(self.get_backup_date, backup_list) 
+        date_list = list(map(self.get_backup_date, backup_list))
         date_list.sort()
         logger.debug("date list: {}".format(date_list))
         files_to_process = [ x for x in backup_list if date_list[-1] in x ]
@@ -647,7 +649,7 @@ def check_index_build(self):
         tobuild = 1
 
         #break the loop either end_time is exceeding from 1 minute or server is successfully started
-        while time.time() < end_time and tobuild <> 0:
+        while time.time() < end_time and tobuild != 0:
 
             command_output, std_err, exit_code = self.run_couchbase_command(
                                         couchbase_command='check_index_build',
@@ -976,18 +978,14 @@ def rename_cluster(self):
 
         logger.debug("rename cluster - exit_code: {} stdout: {} std_err: {}".format(exit_code, command_output, std_err))
 
-
-
-
-
     def start_node_bootstrap(self):
         logger.debug("start start_node_bootstrap")
         self.start_couchbase(no_wait=True)
         end_time = time.time() + 3660
         server_status = Status.INACTIVE
 
         #break the loop either end_time is exceeding from 1 minute or server is successfully started
-        while time.time() < end_time and server_status<>Status.ACTIVE:
+        while time.time() < end_time and server_status != Status.ACTIVE:
             helper_lib.sleepForSecond(1) # waiting for 1 second
             server_status = self.staging_bootstrap_status() # fetching status
             logger.debug("server status {}".format(server_status))
@@ -1068,6 +1066,6 @@ def addnode(self, nodeno, node_def):
 
 
 if __name__ == "__main__":
-    print "Checking Couchbase Class"
+    # print "Checking Couchbase Class"
     test_object = CouchbaseOperation(Resource.ObjectBuilder.set_dsource(True).build())
     print (test_object.get_config_file_path.__doc__)

src/controller/db_exception_handler.py

@@ -47,7 +47,7 @@ def __new__(mcs, caller_name, caller_base_name, attributes_in_caller):
             return super(DatabaseExceptionHandlerMeta, mcs).__new__(mcs, caller_name, caller_base_name,
                                                                     attributes_in_caller)
         except Exception as err:
-            logger.debug("Exception occurred in metaclass: {}".format(err.message))
+            logger.debug("Exception occurred in metaclass: {}".format(str(err)))
             raise
 
     @classmethod
@@ -94,13 +94,13 @@ def wrapper_function(*args, **kwargs):
                 raise
 
             except Exception as error:
-                logger.debug("Caught Exception : {}".format(error.message))
+                logger.debug("Caught Exception : {}".format(str(error)))
                 logger.debug("pioro")
                 ttype, value, traceb = sys.exc_info()
                 logger.debug("type: {}, value: {}".format(ttype, value))
                 logger.debug("trackback")
                 logger.debug(traceback.format_exc())   
-                mcs._exception_generator_factory(error.message)
+                mcs._exception_generator_factory(str(error))
 
         return wrapper_function
 

src/controller/helper_lib.py

@@ -21,7 +21,7 @@
 import time
 from datetime import datetime
 
-import db_commands.constants
+import db_commands
 from db_commands.commands import CommandFactory
 from db_commands.constants import DEFAULT_CB_BIN_PATH
 from dlpx.virtualization.platform.exceptions import UserError
@@ -240,7 +240,7 @@ def filter_bucket_name_from_output(bucket_output):
     logger.debug("filter input: {}".format(bucket_output))
     logger.debug("filter input: {}".format(len(bucket_output)))
     if bucket_output != []:
-        output = map(lambda x: x["name"], bucket_output)
+        output = list(map(lambda x: x["name"], bucket_output))
     logger.debug("Bucket list: {}".format(output))
     return output
 
@@ -337,7 +337,7 @@ def check_dir_present(connection, dir):
             logger.debug("dir path found {} ".format(dir))
             return True
     except Exception as err:
-        logger.debug("directory path is absent: {}".format(err.message))
+        logger.debug("directory path is absent: {}".format(str(err)))
     return False
 
 
@@ -367,8 +367,8 @@ def unmount_file_system(rx_connection, path):
     try:
         utilities.execute_bash(rx_connection, CommandFactory.unmount_file_system(path))
     except Exception as err:
-        logger.debug("error here {}".format(err.message))
-        raise UnmountFileSystemError(err.message)
+        logger.debug("error here {}".format(str(err)))
+        raise UnmountFileSystemError(str(err))
 
 
 def get_bucket_size_in_MB(bucket_size, bkt_name_size):
@@ -402,7 +402,7 @@ def check_stale_mountpoint(connection, path):
             return False
         else:
             logger.error("df retured error - stale mount point or other error")
-            logger.error("stdout: {} stderr: {} exit_code: {}".format(output.encode('utf-8'), stderr.encode('utf-8'), exit_code))
+            logger.error("stdout: {} stderr: {} exit_code: {}".format(output, stderr, exit_code))
             return True
     else:
         return False
@@ -415,7 +415,7 @@ def check_server_is_used(connection, path):
     output, stderr, exit_code = utilities.execute_bash(connection, CommandFactory.mount())
     if exit_code != 0:
         logger.error("mount retured error")
-        logger.error("stdout: {} stderr: {} exit_code: {}".format(output.encode('utf-8'), stderr.encode('utf-8'), exit_code))
+        logger.error("stdout: {} stderr: {} exit_code: {}".format(output, stderr, exit_code))
         raise UserError("Problem with reading mounted file systems", "Ask OS admin to check mount", stderr)
     else:
         # parse a mount output to find another Delphix mount points

src/controller/resource_builder.py

@@ -34,7 +34,7 @@
 #######################################################################################################################
 
 import logging
-from db_exception_handler import DatabaseExceptionHandlerMeta
+from controller.db_exception_handler import DatabaseExceptionHandlerMeta
 
 logger = logging.getLogger(__name__)