-
Notifications
You must be signed in to change notification settings - Fork 0
add dotnet new templates (razor view, api controller, mvc controller) #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/ProjectTemplates/Web.ItemTemplates/content/RazorView/.template.config/template.json
Outdated
Show resolved
Hide resolved
...plates/Web.ItemTemplates/content/RazorView/.template.config/localize/templatestrings.en.json
Show resolved
Hide resolved
@phenning - Can you please help take a look if anything stands out? These are pretty basic item templates. |
@vijayrkn is there a specific problem, or just a general review? @deepchoudhery I'm assuming we aren't expecting these to show up in VS right away (they won't as authored), as we need to solve the problem on how to suppress the current vstemplate versions of these templates. |
src/ProjectTemplates/Web.ItemTemplates/content/ApiController/ValueController.cs
Show resolved
Hide resolved
Just a general review. We are not planning to ship these in VS. This is to move the templates out of the scaffolding repo. VS is already relying on the item templates that are shipped in VS. |
Will these ship in the SDK? I know we wouldn't have them dynamically show up in VS when they do, due to missing metadata to enable it. If we would want to invoke them from vs, we could probably figure out a way to invoke them from the vstemplate stubs instead of the content in the vstemplate. Would probably need a custom wizard, or modification of our existing vstemplate/template engine wizard to support the scenario. |
src/ProjectTemplates/Web.ItemTemplates/content/ApiController/.template.config/template.json
Outdated
Show resolved
Hide resolved
src/ProjectTemplates/Web.ItemTemplates/content/ApiController/.template.config/template.json
Outdated
Show resolved
Hide resolved
...es/Web.ItemTemplates/content/ApiController/.template.config/localize/templatestrings.en.json
Outdated
Show resolved
Hide resolved
src/ProjectTemplates/Web.ItemTemplates/content/MvcController/.template.config/template.json
Outdated
Show resolved
Hide resolved
...es/Web.ItemTemplates/content/MvcController/.template.config/localize/templatestrings.en.json
Outdated
Show resolved
Hide resolved
src/ProjectTemplates/Web.ItemTemplates/content/MvcController/.template.config/template.json
Outdated
Show resolved
Hide resolved
src/ProjectTemplates/Web.ItemTemplates/content/RazorView/.template.config/template.json
Outdated
Show resolved
Hide resolved
For now, we have vstemplates for all of these item templates. But we can definitely consider moving to these in the future to have 1 source of truth. |
The names |
I think we can delete the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left some comments that we should review.
added new
dotnet new
web item templatesRazor View:
view
dotnet new page -np
I guess so disregard this for nowAPI Controller:
apiController
--actions
to add one with read/write actions.MVC Controller:
mvcController
--actions
to add one with read/write actions.