Skip to content

feat: update to angular 12 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 23, 2021

Conversation

jafin
Copy link
Contributor

@jafin jafin commented Dec 22, 2021

  • Update component to Angular 12
  • Replace TSLint with ESLint

@jafin jafin marked this pull request as ready for review December 23, 2021 09:47
Copy link
Owner

@davidwalschots davidwalschots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I have taken the liberty to modify the node version the build pipeline uses to v14. Some small remarks here and there. Looking forward to getting this merged!

Do you by any chance plan on updating to Angular 13 right after this PR?

@davidwalschots davidwalschots changed the title feat (Angular12): Update to Angular 12 feat: update to angular 12 Dec 23, 2021
-Fix gitignore,
-set package-lock back to 12.0.0
-fix indenting on app.component
@jafin
Copy link
Contributor Author

jafin commented Dec 23, 2021

Do you by any chance plan on updating to Angular 13 right after this PR?

No actual plan to go to v13 at the moment for me.

@davidwalschots davidwalschots merged commit b1f67a6 into davidwalschots:master Dec 23, 2021
@jafin
Copy link
Contributor Author

jafin commented Dec 23, 2021

@davidwalschots thanks for fixing up the PR!

@jafin jafin deleted the feat/angular12 branch December 23, 2021 22:21
@davidwalschots
Copy link
Owner

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants