feat(alloc): add estrdup #444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qard
force-pushed
the
add-estrdup
branch
3 times, most recently
from
9d9d00e to
b3a46cd
Compare
Pull Request Test Coverage Report for Build 15651099932Details
💛 - Coveralls |
Qard
force-pushed
the
add-estrdup
branch
3 times, most recently
from
b4f27f1 to
9b7e529
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds estrdup to alloc. This is needed with SAPI when ZTS is enabled as file_handles need their input path to be allocated in the PHP memory manager. I've also added a unit test for emalloc while I was in there, along with using efree, and added a cfg gate to a test which depended on anyhow errors.
I've omitted the
docsrs_bindings.rsbinding update for now until we figure out what the solution is to generating those correctly.