Skip to content

Conversation

alekitto
Copy link
Contributor

@alekitto alekitto commented May 4, 2025

In windows, where command can return more than one line; this will cause the following error to be emitted when trying to invoke php -i:

The filename, directory name, or volume label syntax is incorrect. (os error 123)

This PR provides a fix for this error, taking only the first line of the output.

@Xenira
Copy link
Collaborator

Xenira commented May 5, 2025

@alekitto Thank you for the contribution!

Would you mind resolving the clippy errors?
Looks fine otherwise but will have a closer look after work today.

@coveralls
Copy link

coveralls commented May 5, 2025

Pull Request Test Coverage Report for Build 14830846079

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 14.14%

Totals Coverage Status
Change from base Build 14673396328: 0.0%
Covered Lines: 553
Relevant Lines: 3911

💛 - Coveralls

@alekitto alekitto force-pushed the master branch 2 times, most recently from 0b6a9c5 to 48bfae0 Compare May 5, 2025 06:55
@Xenira Xenira merged commit 78d2499 into davidcole1340:master May 5, 2025
35 checks passed
@davidcole1340 davidcole1340 mentioned this pull request May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants