-
Notifications
You must be signed in to change notification settings - Fork 78
refac: Make rename as Trait && separate to common rename, method_rename #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bf4a705
to
74a88e5
Compare
@Norbytus thank you for this contribution. I like this approach. |
74a88e5
to
5c1bc2a
Compare
@Xenira Also i fix magic method name, https://www.php.net/manual/en/language.oop5.magic.php I hope it not make any bc for old version |
If I see this correctly this breaks the functionality. The idea was to rename |
Ok, I will revert this changes |
a244b48
to
1853406
Compare
@Norbytus I added the explicit test cases back in, as I find those are usually better. Seems like they found a problem as well. Do you want to have a look at it, or should I fix them. |
Ohhh, i will fix it. Thanks. I really miss there is mapping from __snake to __camel |
dbbd58d
to
391cda9
Compare
391cda9
to
5353153
Compare
2cd7738
to
a9dbedf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all your effort. Looks good to me :)
Cool, i think im done. But i make two issue while write test) |
I see how you @Xenira changed renaming, maybe change it to trait for common rename things and method?