feat(zts): set lock per thread on zts build #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelwurtz
force-pushed
the
feat/avoid-global-lock
branch
from
5f4809c to
0b2f7e3
Compare
Xenira
requested changes
Mar 22, 2025
joelwurtz
force-pushed
the
feat/avoid-global-lock
branch
from
0b2f7e3 to
992b938
Compare
Xenira
reviewed
Mar 22, 2025
joelwurtz
force-pushed
the
feat/avoid-global-lock
branch
from
992b938 to
6b2128b
Compare
Xenira
approved these changes
Mar 26, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since on zts each thread gets its own globals (at the exception of sapi_module), i updated the lock to be on local thread (instead of static) so we can update / get globals without getting lock by another thread when in ZTS