Resolve security vulnerabilities #373
Conversation
petrovicboban
force-pushed
the
master
branch
2 times, most recently
from
6164ee4 to
890bd63
Compare
go.mod
Outdated
| @@ -25,7 +25,7 @@ require ( | |||
| k8s.io/apimachinery v0.21.0 | |||
| k8s.io/cli-runtime v0.21.0 | |||
| k8s.io/client-go v0.21.0 | |||
| k8s.io/helm v2.16.12+incompatible | |||
| k8s.io/helm/v3 v3.6.1 | |||
There was a problem hiding this comment.
This will never work as we still need the k8s.io/helm pkg for helm v2 support and k8s.io/helm/v3 is for helm 3.
petrovicboban
force-pushed
the
master
branch
from
890bd63 to
c1e03db
Compare
petrovicboban
force-pushed
the
master
branch
from
c1e03db to
9261b4f
Compare
|
Helm v2 is deprecated for more than a year per https://helm.sh/blog/helm-v2-deprecation-timeline/, there are zero support for this version, even from security standpoint. What's the point to maintaining helm v2 support here? Users who still use helm v2 can use older version of helm-diff. Can we please just drop helm v2 support already? |
@z0rc Maybe. I don't personally use helm v2 but I still occasionally see some users using helm v2 and helm-diff with helmfile and I don't know what i should do for them. Anyway, helm-diff doesn't seem to be affected by the cve of helm and if you use helm-diff with helm v3 you have even less change of being affected by that cve. #372 (comment) |
Fixes #372