PECOBLR-86 improve logging on python driver #556
Conversation
saishreeeee
requested review from
deeksha-db,
samikshya-db,
jprakash-db,
yunbodeng-db,
jackyhu-db and
benc-db
as code owners
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
src/databricks/sql/client.py
Outdated
| @@ -214,6 +214,8 @@ def read(self) -> Optional[OAuthToken]: | |||
| # use_cloud_fetch | |||
| # Enable use of cloud fetch to extract large query results in parallel via cloud storage | |||
|
|
|||
| logger.debug(f"Connection.__init__(server_hostname={server_hostname}, http_path={http_path})") | |||
There was a problem hiding this comment.
try to use lazy logging
src/databricks/sql/thrift_backend.py
Outdated
| @@ -390,6 +392,8 @@ def attempt_request(attempt): | |||
|
|
|||
| # TODO: don't use exception handling for GOS polling... | |||
|
|
|||
| logger.debug(f"ThriftBackend.attempt_request: HTTPError: {err}") | |||
There was a problem hiding this comment.
When handling an error, try to log error and not debug
src/databricks/sql/thrift_backend.py
Outdated
| @@ -404,6 +408,7 @@ def attempt_request(attempt): | |||
| else: | |||
| raise err | |||
| except OSError as err: | |||
| logger.debug(f"ThriftBackend.attempt_request: OSError: {err}") | |||
There was a problem hiding this comment.
same, for error cases preferrable to use logger.error
|
can you look into the failing tests as well |
|
Also can you update the PR description |
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
saishreeeee
force-pushed
the
PECOBLR-86-improve-logging-on-python-driver
branch
from
2485a22 to
0b04de7
Compare
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
Signed-off-by: Sai Shree Pradhan <[email protected]>
Signed-off-by: Sai Shree Pradhan <[email protected]>
Signed-off-by: Sai Shree Pradhan <[email protected]>
saishreeeee
force-pushed
the
PECOBLR-86-improve-logging-on-python-driver
branch
from
0b04de7 to
0adfedd
Compare
Signed-off-by: Sai Shree Pradhan <[email protected]>
Signed-off-by: Sai Shree Pradhan <[email protected]>
What type of PR is this?
Description
Improve logging on python driver
How is this tested?
Related Tickets & Documents
PECOBLR-86