Fix svd flip #595
Merged
Fix svd flip #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dask_ml/utils.py
Outdated
| @@ -23,8 +23,37 @@ | |||
| logger = logging.getLogger() | |||
|
|
|||
|
|
|||
| def svd_flip_with_copy(u, v, u_based_decision=True): | |||
There was a problem hiding this comment.
Rather than duplicating the entire implementation, can you copy the inputs and set them to not be readonly?
|
Thank you, @TomAugspurger, for the reply. Could you instruct me how to construct a read only dask array? |
|
Dask Arrays don't really have a "readonly" concept. It'd be the underlying
NumPy array that's readonly.
…On Mon, Dec 30, 2019 at 7:50 AM Keisuke Fujii ***@***.***> wrote:
Thank you, @TomAugspurger <https://github.com/TomAugspurger>, for the
reply.
Could you instruct me how to construct a read only dask array?
I'll add a test for this case.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#595?email_source=notifications&email_token=AAKAOIS5GK4RFQF75KICQEDQ3H4DTA5CNFSM4J6YXYQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH2K6JY#issuecomment-569683751>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKAOIXJ2PJQAKWBCF7SRQLQ3H4DTANCNFSM4J6YXYQA>
.
|
|
Ok. Then probably I can do this. |
|
Added a test. |
|
I like that when @fujiisoup says "days" he actually means "hours" :) |
:) Thanks! These changes look perfect. The failure against scikit-learn master looks unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @demaheim
This adds a workaround for #592
I'm not sure why but for some reason, the array becomes sometimes read-only and cannot do the inplace multiplication. Large PCA fails because of this issue.
It may not be a perfect fix but it works for large arrays > 1TB.
Please let me know if anyone has better idea to fix this.