-
Notifications
You must be signed in to change notification settings - Fork 82
Support hot reload over websocket #2616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
26b2a30
renamed DWDS injector parameter
jyameo 23b08f1
updated chromeProxyService to perform hotreload with websockets
jyameo ba7942a
updated changelog
jyameo 8b34746
merge main and updated client.dart to fetchLibrariesForHotReload when…
jyameo 0a1d21d
applied dart format
jyameo d792bd7
remove newline in changelog
jyameo 775fbf2
updated error message
jyameo 2dbfa1f
implemented _performWebSocketFetchLibrariesForHotReload
jyameo c4d835e
applied dart format
jyameo 13aaa18
Merge branch 'main' into tmp-no-chrome
jyameo 159d82d
reverted code to remove fetchLibrariesForHotReload websocket logic
jyameo f35e730
applied dart format
jyameo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file | ||
// for details. All rights reserved. Use of this source code is governed by a | ||
// BSD-style license that can be found in the LICENSE file. | ||
|
||
library hot_reload_request; | ||
|
||
import 'package:built_value/built_value.dart'; | ||
import 'package:built_value/serializer.dart'; | ||
|
||
part 'hot_reload_request.g.dart'; | ||
|
||
/// A request to hot reload the application. | ||
abstract class HotReloadRequest | ||
implements Built<HotReloadRequest, HotReloadRequestBuilder> { | ||
static Serializer<HotReloadRequest> get serializer => | ||
_$hotReloadRequestSerializer; | ||
|
||
/// A unique identifier for this request. | ||
String get id; | ||
|
||
HotReloadRequest._(); | ||
factory HotReloadRequest([void Function(HotReloadRequestBuilder) updates]) = | ||
_$HotReloadRequest; | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file | ||
// for details. All rights reserved. Use of this source code is governed by a | ||
// BSD-style license that can be found in the LICENSE file. | ||
|
||
library hot_reload_response; | ||
|
||
import 'package:built_value/built_value.dart'; | ||
import 'package:built_value/serializer.dart'; | ||
|
||
part 'hot_reload_response.g.dart'; | ||
|
||
/// A response to a hot reload request. | ||
abstract class HotReloadResponse | ||
implements Built<HotReloadResponse, HotReloadResponseBuilder> { | ||
static Serializer<HotReloadResponse> get serializer => | ||
_$hotReloadResponseSerializer; | ||
|
||
/// The unique identifier matching the request. | ||
String get id; | ||
|
||
/// Whether the hot reload succeeded on the client. | ||
bool get success; | ||
|
||
/// An optional error message if success is false. | ||
@BuiltValueField(wireName: 'error') | ||
String? get errorMessage; | ||
|
||
HotReloadResponse._(); | ||
factory HotReloadResponse([void Function(HotReloadResponseBuilder) updates]) = | ||
_$HotReloadResponse; | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.