Prepare for dart 3.0 alpha changes: use sdk directory copy for tests #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

annagrin wants to merge 3 commits into dart-lang:master from annagrin:annagrin/rename-sdk-assets

Contributor

annagrin commented Jan 14, 2023 •

edited

Loading

Prepare for dart 3.0 alpha changes:

Handle assets renamed or moved in the SDK (see Cleanup DDC files copied to the released SDK for Dart 3.0 sdk#50700)
Simplify layout code and make SDK layout names consistent.
Make a copy of SDK before generating assets and run tests in that copy.
Update tests.

Towards: #1878

annagrin commented

View reviewed changes

dwds/lib/src/utilities/sdk_layout.dart Outdated Show resolved Hide resolved

annagrin commented

View reviewed changes

dwds/tool/pub_upgrade.sh Outdated Show resolved Hide resolved

annagrin commented

View reviewed changes

dwds/tool/pub_upgrade.sh Outdated Show resolved Hide resolved

annagrin commented

View reviewed changes

fixtures/_testCircular1Sound/pubspec.yaml Outdated Show resolved Hide resolved

annagrin commented

View reviewed changes

frontend_server_client/CHANGELOG.md Outdated Show resolved Hide resolved

annagrin commented

View reviewed changes

frontend_server_client/example/web_client.dart Outdated Show resolved Hide resolved

annagrin commented

View reviewed changes

webdev/test/e2e_test.dart Show resolved Hide resolved

annagrin commented

View reviewed changes

frontend_server_client/CHANGELOG.md Outdated Show resolved Hide resolved

annagrin marked this pull request as draft

January 19, 2023 02:41

nshahan reviewed

View reviewed changes

Contributor

nshahan left a comment

For all of the pubspec.yaml files getting updated in this file the upper bound on the SDK constraint is still <3.0.0. WDYT? When should we be bumping this to <4.0.0?

dwds/lib/src/utilities/sdk_layout.dart Show resolved Hide resolved

dwds/lib/src/utilities/sdk_layout.dart Outdated Show resolved Hide resolved

dwds/test/sdk_asset_generator_test.dart Show resolved Hide resolved

dwds/test/sdk_configuration_test.dart Outdated Show resolved Hide resolved

frontend_server_client/example/web_client.dart Outdated Show resolved Hide resolved

frontend_server_client/lib/src/dartdevc_frontend_server_client.dart Outdated Show resolved Hide resolved

annagrin marked this pull request as ready for review

January 19, 2023 20:19

annagrin requested review from nshahan, elliette and jakemac53

January 19, 2023 20:19

annagrin commented

View reviewed changes

dwds/lib/src/utilities/sdk_layout.dart Show resolved Hide resolved

dwds/test/sdk_asset_generator_test.dart Show resolved Hide resolved

dwds/test/sdk_configuration_test.dart Outdated Show resolved Hide resolved

frontend_server_client/example/web_client.dart Outdated Show resolved Hide resolved

frontend_server_client/example/web_client.dart Outdated Show resolved Hide resolved

Contributor Author

annagrin commented Jan 19, 2023

For all of the pubspec.yaml files getting updated in this file the upper bound on the SDK constraint is still <3.0.0. WDYT? When should we be bumping this to <4.0.0?

I think so (even if it works now due to the semver misuse:)

elliette reviewed

View reviewed changes

dwds/lib/sdk_configuration.dart Show resolved Hide resolved

annagrin marked this pull request as draft

January 24, 2023 03:10

Contributor Author

annagrin commented Jan 24, 2023

I am going to split this PR as it is getting too big:

Make sure tests run in a copy of the sdk directory.
Handle SDK layout change.

annagrin mentioned this pull request

Prepare for dart 3.0.0 alpha release #1878

Closed

13 tasks


          Handle SDK layout update:

- change min SDK constraint to 3.0.0-134.0.dev
- update build_web_compilers to ^4.0.0
- update build_runner to ^2.4.0
- update SDK paths in code
- remove CI testing on stable and add testing on main

annagrin force-pushed the annagrin/rename-sdk-assets branch from febb366 to 019b039 Compare

January 24, 2023 19:27

Anna Gringauze added 2 commits

January 24, 2023 11:34


          Switch back to analyzing on dev channel

14902d8


          Run tests and generate missing assets in a copy of the SDK directory.

b20a89f

annagrin force-pushed the annagrin/rename-sdk-assets branch from 690989d to b20a89f Compare

January 24, 2023 19:50

annagrin changed the title ~~Prepare for dart 3.0 alpha changes: handle renamed assets~~ Prepare for dart 3.0 alpha changes: use sdk directory copy for tests

Contributor Author

annagrin commented Feb 16, 2023

closing - replaced by #1967

annagrin closed this

annagrin mentioned this pull request

Prepare for dart 3.0 stable - allow for SDK <4.0 #1900

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet