Migrate a handful of tests to null-safety #1715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annagrin
approved these changes
Aug 8, 2022
| }); | ||
|
|
||
| test('set breakpoint', () async { | ||
| final line = await context.findBreakpointLine( | ||
| 'printLocal', isolate.id, mainScript); | ||
| 'printLocal', isolate.id!, mainScript); |
There was a problem hiding this comment.
can we declare an isolateId variable instead of asserting on isolate.id!?
| final bp = await service.addBreakpointWithScriptUri( | ||
| isolate.id, mainScript.uri, line); | ||
| isolate.id!, mainScript.uri!, line); |
There was a problem hiding this comment.
Maybe the same for mainScript.uri?
| }); | ||
|
|
||
| tearDown(() async { | ||
| await service.resume(isolate.id); | ||
| await service.resume(isolate.id!); |
There was a problem hiding this comment.
Similar for isolate.id here, as it looks like it is used in many places.
| expect( | ||
| instance, | ||
| isA<Instance>().having( | ||
| (instance) => instance.classRef.name, | ||
| (instance) => instance.classRef!.name, |
There was a problem hiding this comment.
I wonder if we should add an expectation of the variableName being non-null here as well, WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates the following tests to null-safety: