Skip to content

Migrate expression_compiler_service_test.dart to null-safety #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2022
Merged

Migrate expression_compiler_service_test.dart to null-safety #1693

merged 1 commit into from
Jul 21, 2022

Conversation

elliette
Copy link
Contributor

No description provided.

@elliette elliette requested a review from annagrin July 19, 2022 23:48
annagrin
annagrin reviewed Jul 20, 2022
View reviewed changes
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Elliott! Left a comment asking for an additional check that probably should have been present there from the beginning:)

@annagrin
Copy link
Contributor

Thanks Elliott, sorry for the detour into type checking. Let's revert the last commit and keep your version.

@elliette elliette force-pushed the expression-compiler-test branch from 1d5e7de to 4ca2486 Compare July 21, 2022 17:02
@elliette
Copy link
Contributor Author

Thanks Elliott, sorry for the detour into type checking. Let's revert the last commit and keep your version.

Done!

@annagrin annagrin self-requested a review July 21, 2022 17:28
annagrin
annagrin approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elliette elliette merged commit 89fb338 into dart-lang:master Jul 21, 2022
@annagrin annagrin mentioned this pull request Jul 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annagrin annagrin annagrin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elliette @annagrin