Skip to content

Split fakes.dart into null-safe and non null-safe fakes #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 18, 2022

Conversation

elliette
Copy link
Contributor

Temporarily creates a new migrated_fakes.dart file for the purpose of the null-safe migration.

As I migrate files that depend on fixtures/fakes.dart to null-safety, will move those that use fakes with no non null-safe dependencies over to fixtures:migrated_fakes.dart.

@elliette elliette requested a review from annagrin July 13, 2022 20:30
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Elliott, left some comments.

Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elliette elliette merged commit 8aadd89 into dart-lang:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants