Skip to content

Split up dwds.dart so that it only contains the exports for the public API #1681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

elliette
Copy link
Contributor

@elliette elliette commented Jul 11, 2022

Previously dwds.dart contained both the exported public API, and the Dwds class. This change splits it up so that the Dwds class lives in dart_web_debug_service.dart. This way we can import Dwds independently from the rest of the API, which helps with the null-safety migration.

@elliette elliette requested a review from annagrin July 11, 2022 23:34
Copy link
Contributor

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elliette elliette merged commit df020b5 into dart-lang:master Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants