Skip to content

Remove evaluation code that was replaced by expression evaluator #1673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 7, 2022
Merged

Remove evaluation code that was replaced by expression evaluator #1673

merged 6 commits into from
Jul 7, 2022

Conversation

annagrin
Copy link
Contributor

Remove evaluation code that was replaced by expression evaluator:

  • Removed fallback code for evaluate since all our scenarios now support expression evaluation using an expression compiler
  • Removed trying to add non-captured values to the stack since they do not match VM behavior (and also are not consistently available on the stack)
  • Fixed a bug discovered by the change where evaluate was failing with more than one parameter in scope

@annagrin annagrin requested a review from elliette June 30, 2022 18:03
@annagrin
Copy link
Contributor Author

Expression evaluation tests are failing due to an SDK update: dart-lang/sdk#49373

@annagrin annagrin mentioned this pull request Jun 30, 2022
Merged
@annagrin annagrin requested a review from grouma June 30, 2022 21:24
elliette
elliette reviewed Jun 30, 2022
View reviewed changes
elliette
elliette reviewed Jun 30, 2022
View reviewed changes
@annagrin
Copy link
Contributor Author

annagrin commented Jun 30, 2022 •
edited
Loading

Webdev expression evaluation tests are failing due to dart-lang/sdk#49373

Disabled the tests temporarily, filed an issue to enable them after the SDK fix is released: #1675

@annagrin annagrin mentioned this pull request Jun 30, 2022
Closed
@annagrin annagrin requested a review from elliette June 30, 2022 23:39
@annagrin annagrin merged commit 7a27735 into dart-lang:master Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliette elliette elliette approved these changes

@grouma grouma Awaiting requested review from grouma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annagrin @elliette