Debugging experience for patterns needs a cleanup

[annagrin]

• Stepping into the statement on the breakpoint line seems to stuck forever on the same spot

  • I suppose it goes through all ddc statements the patterns has been translated to
  • Can we remove unnecessary locations in source maps?

• Compiler-generated locals appear in the variables window

[nshahan]

@bkonyi Are there any expectations for how stepping through patterns like this works when debugging on the VM?

[bkonyi]

I'm not sure what the behavior will be like as it depends on where we insert breakpoints into generated code. Maybe @alexmarkov will have a better idea or know who will?

[alexmarkov]

Debugger behavior depends on how patterns are lowered in the front-end and how source positions are assigned to the AST nodes.

However, VM has a logic to avoid stopping at the same position repeatedly:

https://github.com/dart-lang/sdk/blob/b8dc6762921aa2fd3ef3c7415d3d7f946ee6f21b/runtime/vm/debugger.cc#L3809-L3814

So even if there are many AST nodes with the same source position, VM would stop at the first one and then skip the rest of the stops, until the source position changes.

[nshahan]

Looking at the screenshot, there are a few initial questions that come to my mind.

• If you set a breakpoint and pause on line 15 then step where would you expect the next pause to be?
• If you set a breakpoint on line 16 and the debugger pauses there do we expect the evaluation to be paused before the when?
• Is there any point that you can hover over variables in the patterns like [var a, int n]to see values?

I don't expect these all to be answered already but I'd like to get the discussion started and I'm not sure who should be involved.

[annagrin]

I am going to split this into a few things:

• (DDC) do not show temp variables generated by CFE
  [Kernel] VariableDeclaration should have more properties to help clients sdk#51554
  [ddc] Generate temp names for the synthetic variables that are generated by the CFE sdk#51589

  Prepare for temporary names update in DDC #2041
  Prepare for variable names changes due to patterns support in DDC #2042

• (dwds) minimize the number of debugger steps through CFE code
  Minimize the number of debugger steps through dart code #2034
  Make debugger skip same locations in dart during stepping. #2043

• (dwds, DevTools, dart-code?) cleanup hover over and evaluation behavior if needed

[annagrin]

All done!