Skip to content

Commit 9914782

Browse files
authored
Use HTTP Multi Server for DevTools (#384)
* Use http multi server for DevTools
1 parent 7d14c3b commit 9914782

File tree

4 files changed

+12
-5
lines changed

4 files changed

+12
-5
lines changed

webdev/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 2.0.5
2+
3+
- Use `HttpMultiServer` to fix bind issues with IPv6 / IPv4.
4+
15
## 2.0.4
26

37
- Fix loading apps in non-chrome browsers in --debug mode

webdev/lib/src/serve/debugger/devtools.dart

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,12 @@ import 'dart:async';
66
import 'dart:io';
77
import 'dart:isolate';
88

9+
import 'package:http_multi_server/http_multi_server.dart';
910
import 'package:path/path.dart' as p;
1011
import 'package:shelf/shelf.dart';
1112
import 'package:shelf/shelf_io.dart';
1213
import 'package:shelf_static/shelf_static.dart';
1314

14-
import '../utils.dart';
15-
1615
/// A server for Dart Devtools.
1716
class DevTools {
1817
final String hostname;
@@ -50,7 +49,10 @@ class DevTools {
5049
: buildHandler(request);
5150
};
5251

53-
var server = await serve(handler, hostname, await findUnusedPort());
52+
var server = hostname == 'localhost'
53+
? await HttpMultiServer.loopback(0)
54+
: await HttpServer.bind(hostname, 0);
55+
serveRequests(server, handler);
5456

5557
return DevTools._(server.address.host, server.port, server);
5658
}

webdev/lib/src/version.dart

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

webdev/pubspec.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: webdev
2-
version: 2.0.4
2+
version: 2.0.5
33
author: Dart Team <[email protected]>
44
homepage: https://github.com/dart-lang/webdev
55
description: >-
@@ -18,6 +18,7 @@ dependencies:
1818
dwds: ^0.3.0
1919
devtools: ^0.0.15-dev.1
2020
http: ^0.12.0
21+
http_multi_server: ^2.0.0
2122
io: ^0.3.2+1
2223
logging: ^0.11.0
2324
pedantic: ^1.5.0

0 commit comments

Comments
 (0)