Replace implicit dynamic with Null in arity checks #675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #674 dynamic is treated as the bottom type for function arguments, but this will soon change. Null will continue to be the bottom type. The question we are asking is "Is this a function that takes one argument", when dynamic is no longer the bottom type the question will become "Is this a function that takes one dynamic argument", and a function which take one argument of a specific type does *not* take a dynamic argument.
grouma
approved these changes
Aug 22, 2017
leafpetersen
approved these changes
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #674
dynamic is treated as the bottom type for function arguments, but this
will soon change. Null will continue to be the bottom type.
The question we are asking is "Is this a function that takes one
argument", when dynamic is no longer the bottom type the question will
become "Is this a function that takes one dynamic argument", and a
function which take one argument of a specific type does not take a
dynamic argument.