Added documentation about out-of-range components to DateTime.parse. #44521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoylen
changed the title
|
@hoylen see review comments on https://dart-review.googlesource.com/c/sdk/+/176680 once they are addressed just push a new commit into your branch and it will be picked up automatically. |
sdk/lib/core/date_time.dart
Outdated
| * them as overflows into the next larger component. | ||
| * For example, "2020-01-42" will be parsed as 2020-02-11, because | ||
| * the last valid date in that month is 2020-01-31, so 42 days is | ||
| * interprted as 31 days of that month plus 11 days into the next month. |
|
Would really love to see this. Is this still being discussed? |
|
This is ready to land by requires rebase. |
|
Rebase done. Ready "to land". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DateTime.parse method accepts out-of-range components. For example, parsing the string "2020-01-42" produces "2020-02-11".
This was raised as a bug in #11189, but after more than 7 years that issue was closed with the solution being "use parseStrict from the intl package" instead.
This pull request simply updates the documentation of DateTime's parse method so that users know: