Skip to content

unhandledExceptionCallback to spawnFunction is ignored. #9012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
floitschG opened this issue Mar 8, 2013 · 9 comments
Closed

unhandledExceptionCallback to spawnFunction is ignored. #9012

floitschG opened this issue Mar 8, 2013 · 9 comments
Labels
closed-obsolete Closed as the reported issue is no longer relevant web-dart2js

Comments

@floitschG
Copy link
Contributor

With https://code.google.com/p/dart/source/detail?r=16186 the spawnFunction received an extra argument: the unhandledExceptionCallback.
It is supposed to be called for unhandled exceptions.

Dart2js currently just ignores it.

@floitschG
Copy link
Contributor Author

Failing test: global_error_handler_test
https://codereview.chromium.org/12434003

Note: with the following patch the test succeeds 50% of the time for me:

@@ -21,6 +21,7 @­@ void startTest(SendPort finishPort, replyPort) {
   firstFunction = () { throw new RuntimeError("ignore exception"); };
   finishFunction = () { finishPort.send("done"); };
   new Timer(Duration.ZERO, runFunctions);

  • new Timer(const Duration(seconds: 1), () {});
     }
     
     runTest() {

@floitschG
Copy link
Contributor Author

Also see issue #9024.

@floitschG
Copy link
Contributor Author

Issue #9024 is a reminder to enable a test, when this issue (9012) is resolved.

@kasperl
Copy link

kasperl commented Apr 22, 2013

Added this to the Later milestone.

@kasperl
Copy link

kasperl commented May 23, 2013

Added TriageForM5 label.

@kasperl
Copy link

kasperl commented May 28, 2013

Removed TriageForM5 label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@lrhn
Copy link
Member

lrhn commented Oct 29, 2014

Added AssumedStale label.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-obsolete Closed as the reported issue is no longer relevant web-dart2js
Projects
None yet
Development

No branches or pull requests

3 participants