Skip to content

Test language/ToplevelCollision2Test fails on dartc #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DartBot opened this issue Nov 30, 2011 · 6 comments
Closed

Test language/ToplevelCollision2Test fails on dartc #647

DartBot opened this issue Nov 30, 2011 · 6 comments
Assignees
@scheglov
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue

Comments

@DartBot
Copy link

DartBot commented Nov 30, 2011

This issue was originally filed by @mhausner

The test defines a top-level getter and setter with the same name, which is ok. However, dartc reports that the name is already defined.
@DartBot
Copy link
Author

DartBot commented Nov 30, 2011

This comment was originally written by @mhausner

Test cases ToplevelCollision2/00 and ToplevelCollision2/01 currently pass, but for the wrong reason. They are negative tests that produce the compile-time error described above.

@DartBot
Copy link
Author

DartBot commented Dec 8, 2011

This comment was originally written by [email protected]

Set owner to @scheglov.

@scheglov
Copy link
Contributor

Fixed as http://code.google.com/p/dart/issues/detail?id=519

Added Fixed label.

@scheglov
Copy link
Contributor

Re-open, causes problem in release mode.

Added Triaged label.

@scheglov
Copy link
Contributor

Failure log:

=== releaseia32 dartc language/ToplevelCollision2Test/none ===
Path: language/ToplevelCollision2Test/none
error optimizing:JSC_VAR_MULTIPLY_DECLARED_ERROR. Variable unnamed5a0b95$x$named first declared in out/generated_tests/language/ToplevelCollision2Test.dart/ToplevelCollision2Test.dart: at out/generated_tests/language/ToplevelCollision2Test.dart/ToplevelCollision2Test.dart line (unknown line) : (unknown column)
out/generated_tests/language/ToplevelCollision2Test.dart/ToplevelCollision2Test.dart:-1: Closure compiler error: Variable unnamed5a0b95$x$named first declared in out/generated_tests/language/ToplevelCollision2Test.dart/ToplevelCollision2Test.dart:
    -1: // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
error optimizing:JSC_VAR_MULTIPLY_DECLARED_ERROR. Variable unnamed5a0b95$x$named_$lookupRTT first declared in out/generated_tests/language/ToplevelCollision2Test.dart/ToplevelCollision2Test.dart: at out/generated_tests/language/ToplevelCollision2Test.dart/ToplevelCollision2Test.dart line (unknown line) : (unknown column)
out/generated_tests/language/ToplevelCollision2Test.dart/ToplevelCollision2Test.dart:-1: Closure compiler error: Variable unnamed5a0b95$x$named_$lookupRTT first declared in out/generated_tests/language/ToplevelCollision2Test.dart/ToplevelCollision2Test.dart:
    -1: // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Compilation failed with 2 problems.
Command: out/Release_ia32/compiler/bin/dartc_test --optimize --ignore-unrecognized-flags out/generated_tests/language/ToplevelCollision2Test.dart

Probably code generation/optimization problem.

@DartBot
Copy link
Author

DartBot commented Mar 28, 2012

This comment was originally written by [email protected]

Release mode is now a no-op. No more code generation at all in dartc - closing.

Added WontFix label.

@kevmoo kevmoo added closed-not-planned Closed as we don't intend to take action on the reported issue and removed resolution-wont_fix labels Mar 1, 2016
copybara-service bot pushed a commit that referenced this issue Jun 16, 2022
Roll Dart Protobuf Support from 3105588b8e51 to 3149f6f2d323 (3 revis…
56660ad 
…ions)

https://dart.googlesource.com/protobuf/+log/3105588b8e51..3149f6f2d323

2022-06-16 [email protected] Use `dart compile js` instead of `dart2js` in bench builders
2022-06-16 [email protected] Remove `ProtobufContainer` superclass of `CodeGenerator` (#647)
2022-06-16 [email protected] Remove redundant reserved names (#679)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-protobuf-dart-sdk
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Dart Protobuf Support: https://github.com/dart-lang/protobuf/issues
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: [email protected]
Change-Id: I89162783f5edcea85ed56ee2258b71ac390bca7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248761
Reviewed-by: Nate Bosch <[email protected]>
Commit-Queue: Nate Bosch <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
closed-not-planned Closed as we don't intend to take action on the reported issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kevmoo @scheglov @DartBot