`use_if_null_to_convert_nulls_to_bools` does not handle false equality checks?

[pq]

When looking at #58533, I was surprised to find that use_if_null_to_convert_nulls_to_bools doesn't seem to handle cases like this:

List<String>? strings;

bool f() => strings?.isEmpty == false;

I'd expect the preferred way to express this would be:

List<String>? strings;

bool f() => strings?.isEmpty ?? false;

@a14n: do you recall if this was intentional (and I'm forgetting some rationale) or an oversight?

Thanks!

[a14n]

Correct me if I'm wrong but a == false is not the same as a ?? false (it's more !(a ?? true))

[pq]

(Sorry for the noise, need some more coffee before I can get straight what I'm driving at here...)

☕

[a14n]

:) The same comment applies :)

a	a == false	a ?? false	a ?? true	!(a ?? true)
null	false	false	true	false
false	true	false	false	true
true	false	true	true	false

I don't thing !(a ?? true) is easier to understand compared to a == false

[pq]

I just came to the same conclusion. Thanks for bearing with my half-baked thinking!