Skip to content

[CP] [vm/ffi] Fix variadic arguments on MacOS Arm64 #55943

Closed
@dcharkes

Description

@dcharkes

Commit(s) to merge

Target

stable

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/369822

Issue Description

Variadic arguments on Mac Arm64 weren't working correctly due to misalingment.

What is the fix

Distinguishing stack alignment of FFI call arguments between varargs and non-varargs.

Why cherry-pick

To prevent JNIgen having to target the 3.5 master branch for Flutter/Dart.

Risk

Small: It's a couple of lines of code CL (with many lines of code tests).

Issue link(s)

#55471

Extra Info

No response

Metadata

Metadata

Labels

area-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.cherry-pick-approvedLabel for approved cherrypick requestcherry-pick-reviewIssue that need cherry pick triage to approve

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions