[CP] Do not throw during InternetAddress.tryParse

[brianquinlan]

Commit(s) to merge

14cb98e

Target

stable

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/305041

Issue Description

The issue is that some users are debugging their applications with "Break on all exceptions" enabled. Dart 3.0 changed the behavior of HttpClient so that InternetAddress.tryParse is used. This method uses exceptions as part of its implementation, which provokes a debugger break that is confusing to some users.

This occurs on all platforms.

What is the fix

The fix is to not use exceptions internally in InternetAddress.tryParse.

Why cherry-pick

The reason to not cherry pick this PR is because the original implementation is correct.

But, despite heroic attempts by @DanTup, some users were unconvinced and fixing this ASAP seems like the most practical thing to do.

Risk

low

Issue link(s)

flutter/flutter#126650, #52423

Extra Info

No response

[itsjustkevin]

@a-siva could you take a look at this cherry-pick?

@brianquinlan do you see this as a must hotfix?

[brianquinlan]

@itsjustkevin Lots of users seem to have been confused by this issue but certainly it is possible for people to work without the fix.

[a-siva]

People can workaround without the fix but the comments on the issue seem to indicate that people view it as a change from the previous version and seem to think the app is crashing.
The workaround is to have people not use 'break on all exceptions' and from the comments it seemed like it was not a good option for the developers.

[a-siva]

the change lgtm.
Based on the comments in the original issue feel it would improve developer experience, @jacob314 could you chime in on whether it makes sense to cherry pick this change into the hotfix.

[yelmuratoff]

@brianquinlan I installed latest flutter version 3.10.2 with Dart 3.0.2 and this error not fixed(((

[itsjustkevin]

@K1yoshiSho this change is not yet in Dart or Flutter.

[brianquinlan]

@K1yoshiSho When I suggested cherrypicking this for Dart 3.0.2, it had not been released yet and I thought that there was a chance to get it in. My mistake.

[itsjustkevin]

Friendly bump @jacob314