completion_metrics tool, with `--overlay remove-token`, throws InconsistentAnalysisException for flutter/gallery

[srawlins]

Cloning flutter/gallery, and then running flutter pub get, and then running the completion_metrics tool, throws an error:

$ $HOME/code/flutter/bin/dart pkg/analysis_server/tool/code_completion/completion_metrics.dart /Users/srawlins/code/flutter-gallery --overlay remove-token
Analyzing root: "/Users/srawlins/code/flutter-gallery"
Unhandled exception:
InconsistentAnalysisException: Requested result might be inconsistent with previously returned results

#0      AnalysisSessionImpl._checkConsistency (package:analyzer/src/dart/analysis/session.dart:133:7)
#1      AnalysisSessionImpl.getResolvedUnit (package:analyzer/src/dart/analysis/session.dart:119:5)
#2      CompletionMetricsComputer._computeInContext (file:///Users/srawlins/code/dart-sdk/sdk/pkg/analysis_server/tool/code_completion/completion_metrics.dart:1409:16)
<asynchronous suspension>
#3      CompletionMetricsComputer.computeMetrics (file:///Users/srawlins/code/dart-sdk/sdk/pkg/analysis_server/tool/code_completion/completion_metrics.dart:737:7)
<asynchronous suspension>
#4      main (file:///Users/srawlins/code/dart-sdk/sdk/pkg/analysis_server/tool/code_completion/completion_metrics.dart:129:3)
<asynchronous suspension>

It seems to be doing better if I do not pass --overlay remove-token.

[srawlins]

CC @bwilkerson in case you're interested

[bwilkerson]

I'm definitely interested, but @scheglov probably has more context for solving the underlying issue.

[scheglov]

This https://dart-review.googlesource.com/c/sdk/+/241208 seems to fix the exception, now the tool works... and works... and still works.

[srawlins]

Haha, it took 90 minutes to run over flutter/gallery.

[scheglov]

If you are curious, it still runs. Which is concerning, but it uses CPU, so maybe not stuck?

[scheglov]

I think the issue is fixed, but I still was not able to wait until the process is done.

[srawlins]

I'm adding a progress bar here: https://dart-review.googlesource.com/c/sdk/+/241623

[srawlins]

It seems to get waaaaay hung up on lib/codeviewer/code_segments.dart, a 47000 line file. Many many statements, not too many class members.