Skip to content

Tests failed when mock version of meta was updated #48476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bwilkerson opened this issue Feb 26, 2022 · 9 comments
Closed

Tests failed when mock version of meta was updated #48476

bwilkerson opened this issue Feb 26, 2022 · 9 comments
Assignees
@pq
Labels
legacy-area-analyzer Use area-devexp instead. P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@bwilkerson
Copy link
Member

bwilkerson commented Feb 26, 2022 •
edited
Loading

The following tests started failing when the analyzer's mock version of package:meta was updated to include a @Target annotation on _DoNotStore and _OptionalTypeArgs:

AssignmentOfDoNotStoreTest | test_classMemberVariable
AssignmentOfDoNotStoreTest | test_classStaticVariable
AssignmentOfDoNotStoreTest | test_topLevelVariable
AssignmentOfDoNotStoreTest | test_topLevelVariable_assignment_field
AssignmentOfDoNotStoreTest | test_topLevelVariable_assignment_functionExpression
AssignmentOfDoNotStoreTest | test_topLevelVariable_binaryExpression
AssignmentOfDoNotStoreTest | test_topLevelVariable_ternary
InferenceFailureOnFunctionInvocationTest | test_functionType_optionalTypeArgs
ReturnOfDoNotStoreTest | test_returnFromClosureInFunction
ReturnOfDoNotStoreTest | test_returnFromFunction
ReturnOfDoNotStoreTest | test_returnFromGetter
ReturnOfDoNotStoreTest | test_returnFromGetter_binaryExpression
ReturnOfDoNotStoreTest | test_returnFromGetter_ternary
ReturnOfDoNotStoreTest | test_returnFromMethod
ReturnOfDoNotStoreInTestsTest | test_noHintsInTestDir

Either the tests need to be updated or the Target annotations need to be updated.
@bwilkerson bwilkerson added the legacy-area-analyzer Use area-devexp instead. label Feb 26, 2022
@bwilkerson
Copy link
Member Author

@pq

@srawlins srawlins added the P2 A bug or feature request we're likely to work on label Feb 28, 2022
@pq pq self-assigned this Feb 28, 2022
@srawlins
Copy link
Member

srawlins commented Oct 5, 2022

InferenceFailureOnFunctionInvocationTest | test_functionType_optionalTypeArgs is a test which features @optionalTypeArgs on a function-typed parameter, which should be allowed. I guess the Target needs to be updated?

@pq pq mentioned this issue Aug 28, 2023
Closed
@srawlins srawlins added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Mar 14, 2024
@srawlins
Copy link
Member

srawlins commented Apr 5, 2024

Wow, I think I mislabled this. All of the tests backing @doNotStore are marked @FailingTest. 😮

@srawlins srawlins added P1 A high priority bug; for example, a single project is unusable or has many test failures and removed P2 A bug or feature request we're likely to work on labels Apr 5, 2024
@bwilkerson
Copy link
Member Author

Any progress?

@pq
Copy link
Member

pq commented Apr 23, 2024

Ah, sorry. No progress.

@bwilkerson
Copy link
Member Author

Any progress? Do we need to adjust the priority?

@pq
Copy link
Member

pq commented May 22, 2024

No progress. Let me know what you think about priority. If it feels like a real P1, I can shift some energy over to take a look.

@srawlins
Copy link
Member

All of the tests backing @doNotStore are marked @FailingTest.

I think this is still P1. If you're on other P1s at the moment, I can take this one instead.

copybara-service bot pushed a commit that referenced this issue May 23, 2024
@srawlins
meta: Support @doNotStore on constructors and mixins
0d5830e 
There were no tests of this component of the annotation's description:

> The annotation can also be applied to a class to implicitly
> annotate all of the valid members of the class

So I add those as well.

Bug: #48476
Change-Id: If5f0f4c6057f57b4dfd01d8f648110d69fbc5eb4
Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/367880
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>
copybara-service bot pushed a commit that referenced this issue May 24, 2024
@srawlins
analyzer: Fix return_of_do_not_store tests
c45bc06 
Bug: #48476

Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try
Change-Id: I3af9ad950b2ef42717fb84dde4f9b3c22993df05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/367860
Reviewed-by: Phil Quitslund <[email protected]>
Auto-Submit: Samuel Rawlins <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
@srawlins
Copy link
Member

Fixed with c45bc06 and 0d5830e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
legacy-area-analyzer Use area-devexp instead. P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pq @srawlins @bwilkerson