Remove `.packages` from the Dart SDK repo #48275

natebosch · 2022-02-01T21:01:43Z

I dropped a bunch of places reading this file in https://dart-review.googlesource.com/c/sdk/+/211503, but there are still some places that depend on it.

Towards #48275 Change-Id: Ie4fe50d0d5afb04d4d3e7dde55c441e952218cc4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231184 Auto-Submit: Nate Bosch <[email protected]> Reviewed-by: Nicholas Shahan <[email protected]> Commit-Queue: Nicholas Shahan <[email protected]>

Towards #48275 Change-Id: Idfe1de48b7f292b6c89e5b904f74c37232380c6b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231065 Auto-Submit: Nate Bosch <[email protected]> Reviewed-by: Kevin Moore <[email protected]> Commit-Queue: Kevin Moore <[email protected]>

mit-mit · 2022-03-07T12:25:12Z

@natebosch any chance we could assign this issue to you to get the rest removed the SDK repo?

natebosch · 2022-03-07T17:39:57Z

Sure, I am planning to keep pushing on this as I have time.

srawlins · 2022-03-16T18:59:44Z

I just grepped through this repo for "dotPackages", and found references in:

pkg/analyzer/lib/
pkg/front_end/lib/, pkg/front_end/test/, and pkg/front_end/test_cases/
pkg/front_end_server/test/
pkg/vm/bin/kernel_service.dart
tests/lib/isolate/, tests/lib_2/isolate/

natebosch · 2022-03-16T19:25:03Z

I just grepped through this repo for "dotPackages"

Yeah there are still a bunch. Any help cleaning up whatever you find is great.

dotPackages as a variable name can sometimes refer to the path to .dart_tool/package_config.json since some tools were updated to understand either file with the same argument.

scheglov · 2022-03-17T05:16:51Z

There are a few shared tests that use .packages, started failing here.

standalone_2/package/scenarios/both_dir_and_file/prefers_packages_file_test
standalone_2/package/scenarios/packages_file_in_parent/sub/packages_file_in_parent_test
standalone_2/package/scenarios/packages_file_only/packages_file_only_test

mit-mit · 2022-04-08T12:17:44Z

@sigmundch there are a bunch of search hits on .packages in /pkg/compiler/ & /pkg/dev_compiler/ -- is that something the web team can look at in Q2?

mit-mit · 2022-04-08T12:20:22Z

@johnniwinther there are a bunch of search hits on .packages in /pkg/front_end/ -- is that something the CFE team can look at in Q2?

mit-mit · 2022-04-08T12:24:10Z

@sortie I see a bunch of search hits on .packages in /tools.bots -- is that something you can help with?

sigmundch · 2022-04-08T21:39:48Z

I think we should be able to get rid of the web uses of .packages. A big bulk of them come from the modular_test framework, which we created a few years back. That required changing how the framework works, but I made progress on that today via https://dart-review.googlesource.com/c/sdk/+/240651/3 and https://dart-review.googlesource.com/c/sdk/+/240650/2

Embed in the modules.yaml any extra paths needed for package dependencies instead. This is one step to help towards #48275 Change-Id: I22ef02b2b2327a0c798f2fea73d59c758a8bb0bb Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240651 Reviewed-by: Joshua Litt <[email protected]> Commit-Queue: Sigmund Cherem <[email protected]>

sortie · 2022-04-11T09:31:27Z

@mit-mit OK, handled tools/bots in:

https://dart-review.googlesource.com/c/sdk/+/240842
https://dart-review.googlesource.com/c/sdk/+/240843

johnniwinther · 2022-04-11T11:22:59Z

@mit-mit Have we deprecated the feature yet? I'd like to keep testing of the feature as long as we support it.

Bug: #48275 Change-Id: Ief3ff323726bdbb1870e989deb5372d88c3f4f3a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240843 Auto-Submit: Jonas Termansen <[email protected]> Reviewed-by: Alexander Thomas <[email protected]> Commit-Queue: Alexander Thomas <[email protected]>

mit-mit · 2022-05-04T15:02:58Z

@johnniwinther sorry missed your question. Yes, the .packages file has been deprecated since Dart 2.8.

mit-mit · 2022-05-05T13:38:50Z

I'm making some progress in https://dart-review.googlesource.com/c/sdk/+/243625 on removing the generation of the .packages file. There are a lot of failures I don't understand though in the test results for patchset 3 for DDC:
https://ci.chromium.org/ui/p/dart/builders/try/ddc-linux-release-chrome-try/42906/overview

@athomas @sigmundch does this somehow ring a bell to you?

athomas · 2022-05-05T14:24:09Z

@mit-mit Probably something related to the path mangling around https://github.com/dart-lang/sdk/blob/main/pkg/test_runner/lib/src/test_suite.dart#L928

sigmundch · 2022-05-05T18:57:09Z

@mit-mit Funny you ask today, just yesterday I came across the same error.

FYI @sortie also has a step to remove the use of .packages on the bots (see https://dart-review.googlesource.com/c/sdk/+/240842). That prompted me to make a similar change to yours to unblock him (https://dart-review.googlesource.com/c/sdk/+/243643), but also came across the errors on the DDC bots. I haven't yet investigated, but it's possible that the errors are not DDC specific, but more of an infra issue with the test runner or the http server it uses to launch browser tests. I'll try to check later today if I get a chance, but otherwise I'll look tomorrow.

sigmundch · 2022-05-05T23:20:04Z

Turns out the DDC bot failures were due to an issue in the test runner. The test runner was generating an invalid html to bootstraps the ddc code after the change because it used the path of the package configuration file in its logic.

I'm attempting a new run with a fix in https://dart-review.googlesource.com/c/sdk/+/243643

sigmundch · 2022-05-06T03:13:50Z

(and forgot to say, this turned out to be exactly what @athomas suggested initially. At first I didn't put together how that logic connected with DDC, but I landed in that same place after looking at the generated JavaScript)

.dart_tool/package_config.json is already present in each fileset. Bug: #48275 Change-Id: Ib75fd91060f0b9eaeb1446cf65cb8678b2ddc63c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240842 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Jonas Termansen <[email protected]> Reviewed-by: Alexander Thomas <[email protected]>

sortie · 2022-05-10T13:44:31Z

.packages has now been removed from the bots, thanks everyone for helping that along :)

mit-mit · 2022-05-10T13:51:22Z

https://dart-review.googlesource.com/c/sdk/+/243625 has been created to stop generating the .packages file in the SDK

mit-mit · 2022-05-10T13:52:03Z

@natebosch are you aware of any other work for the present issue after /243625 lands?

natebosch · 2022-05-10T19:46:04Z

If /243625 doesn't cause any issues I think that covers the vast majority, though there may be a bit more cleanup to do.

I found a few references - https://dart-review.googlesource.com/c/sdk/+/244046

I'm a little surprised that these references don't cause any issues when you stop creating the .packages file entirely...

Contributes to #48275 Change-Id: I3acb90b91b9b206b69ca0ae311aa43f5954c29a6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243625 Reviewed-by: Nate Bosch <[email protected]> Reviewed-by: Sigmund Cherem <[email protected]> Commit-Queue: Michael Thomsen <[email protected]>

mit-mit · 2022-05-11T13:31:36Z

/243625 and /244046 have both landed 🚀 , so closing this issue

Towards #48275 [email protected] Change-Id: I38cc986937543c5e4d1f2a2cd4c7804d180a2741 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244304 Commit-Queue: Nate Bosch <[email protected]> Reviewed-by: Michael Thomsen <[email protected]> Commit-Queue: Michael Thomsen <[email protected]> Auto-Submit: Nate Bosch <[email protected]>

natebosch added type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable area-sdk Use area-sdk for general purpose SDK issues (packaging, distribution, …). labels Feb 1, 2022

natebosch mentioned this issue Feb 2, 2022

Stop producing .packages #47431

Closed

2 tasks

mit-mit mentioned this issue Feb 7, 2022

[breaking change] discontinue .packages file #48272

Closed

13 tasks

mit-mit changed the title ~~Remove .packages from this repo~~ Remove .packages from the Dart SDK repo Feb 7, 2022

mit-mit assigned natebosch Mar 7, 2022

mit-mit closed this as completed May 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove `.packages` from the Dart SDK repo #48275

Remove `.packages` from the Dart SDK repo #48275

natebosch commented Feb 1, 2022

mit-mit commented Mar 7, 2022

natebosch commented Mar 7, 2022

srawlins commented Mar 16, 2022

natebosch commented Mar 16, 2022

scheglov commented Mar 17, 2022

mit-mit commented Apr 8, 2022 •

edited

Loading

mit-mit commented Apr 8, 2022 •

edited

Loading

mit-mit commented Apr 8, 2022

sigmundch commented Apr 8, 2022

sortie commented Apr 11, 2022

johnniwinther commented Apr 11, 2022

mit-mit commented May 4, 2022

mit-mit commented May 5, 2022

athomas commented May 5, 2022

sigmundch commented May 5, 2022

sigmundch commented May 5, 2022

sigmundch commented May 6, 2022

sortie commented May 10, 2022

mit-mit commented May 10, 2022

mit-mit commented May 10, 2022

natebosch commented May 10, 2022

mit-mit commented May 11, 2022

Remove .packages from the Dart SDK repo #48275

Remove .packages from the Dart SDK repo #48275

Comments

natebosch commented Feb 1, 2022

mit-mit commented Mar 7, 2022

natebosch commented Mar 7, 2022

srawlins commented Mar 16, 2022

natebosch commented Mar 16, 2022

scheglov commented Mar 17, 2022

mit-mit commented Apr 8, 2022 • edited Loading

mit-mit commented Apr 8, 2022 • edited Loading

mit-mit commented Apr 8, 2022

sigmundch commented Apr 8, 2022

sortie commented Apr 11, 2022

johnniwinther commented Apr 11, 2022

mit-mit commented May 4, 2022

mit-mit commented May 5, 2022

athomas commented May 5, 2022

sigmundch commented May 5, 2022

sigmundch commented May 5, 2022

sigmundch commented May 6, 2022

sortie commented May 10, 2022

mit-mit commented May 10, 2022

mit-mit commented May 10, 2022

natebosch commented May 10, 2022

mit-mit commented May 11, 2022

Remove `.packages` from the Dart SDK repo #48275

Remove `.packages` from the Dart SDK repo #48275

mit-mit commented Apr 8, 2022 •

edited

Loading

mit-mit commented Apr 8, 2022 •

edited

Loading