Skip to content

[Analyzer] Implement changes to null safety checking for local variables. #43100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
leafpetersen opened this issue Aug 19, 2020 · 4 comments
Closed

[Analyzer] Implement changes to null safety checking for local variables. #43100

leafpetersen opened this issue Aug 19, 2020 · 4 comments
Assignees
@stereotype441
Labels
legacy-area-analyzer Use area-devexp instead. NNBD Issues related to NNBD Release type-enhancement A request for a change that isn't a bug

Comments

@leafpetersen
Copy link
Member

Small set of changes to the errors and warnings around local variables landed here.

Tests for the the definite assignment based errors landed here.

Tests for the inference and promotion section to follow.

cc @scheglov
@leafpetersen leafpetersen added legacy-area-analyzer Use area-devexp instead. NNBD Issues related to NNBD Release labels Aug 19, 2020
@leafpetersen leafpetersen mentioned this issue Aug 19, 2020
Closed
@scheglov
Copy link
Contributor

First portion - reading.
https://dart-review.googlesource.com/c/sdk/+/159382

co19 should be updated.
dart-lang/co19#913

@scheglov scheglov self-assigned this Aug 20, 2020
dart-bot pushed a commit that referenced this issue Aug 20, 2020
@scheglov
Issue 43100. Verify local variable reads for null safety.
25edea3 
Bug: #43100
Change-Id: Ia8ece4de32f65d7912e534ce61936a45f2c768c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159382
Reviewed-by: Brian Wilkerson <[email protected]>
dart-bot pushed a commit that referenced this issue Aug 22, 2020
@scheglov
Add write tests, fix write_error_test.dart
afd6344 
Bug: #43100
Change-Id: Ib01192e73905ae1c431491e89e269fd25c6cd9cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159680
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
@leafpetersen leafpetersen mentioned this issue Sep 3, 2020
Closed
@franklinyow franklinyow added the type-enhancement A request for a change that isn't a bug label Sep 3, 2020
@scheglov
Copy link
Contributor

We have one test that fails: tests/language/nnbd/definite_assignment/definite_assignment_error_test.dart
AFAIK this is #42990

@scheglov scheglov removed their assignment Sep 18, 2020
@leafpetersen
Copy link
Member Author

New tests for the inference and initialization portion landed here

Failing: language/nnbd/inference/variable_initialization_promotion_test
Passing: language/nnbd/inference/variables_initialized_to_null_test

@stereotype441 stereotype441 mentioned this issue Sep 27, 2020
Merged
12 tasks
@stereotype441 stereotype441 self-assigned this Sep 29, 2020
@stereotype441
Copy link
Member

All of these tests are now passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stereotype441 stereotype441

Labels
legacy-area-analyzer Use area-devexp instead. NNBD Issues related to NNBD Release type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@stereotype441 @scheglov @leafpetersen @franklinyow