Ranking/sorting of code completion is worse with suggestion sets

[DanTup]

This was raised in Dart-Code, but I think needs to be fixed in the server. I thought there was already an open issue about this here but cannot locate it. I don't know if it's easily fixable, but seems like we should have an issue tracking it here.

This is what completion looked like before:

And this is what it looks like using the new auto-import completions:

Based on comments from @scheglov I think the issue here is that the declared type of the property does not match the one the user wants (because it just uses the parsed AST) and therefore doesn't get ranked at the top.

[maRci002]

To sum up there was a community request to enable completion for non imported identifiers and problems occur if the client subscribe for completion service:

request: {
  "id": "some_id"
  "method": "completion.setSubscriptions"
  "params": {
    "subscriptions": ["AVAILABLE_SUGGESTION_SETS"]
  }
}

Thanks to @scheglov the problem was helped a bit on the dev channel but the relevance is still high in the local file for all the identifiers.

• current behavior on dev channel
  1. list all identifiers from current file
  2. list every other identifiers from other files sorted by relevance order
• old behavior
  1. list all identifiers from current file
  2. list every other identifiers from other files sorted by alphabetical order

Current workarounds (if you are satisfied with the manual import):

• Visual Studio Code:
  • uncheck: Auto Import Completions ( "dart.autoImportCompletions": false, )
• Android studio /IntelliJ
  • make sure you are using at most IntelliJ IDEA 2018.3.6 / Android Studio 3.4.2
  • you can use newest Android Studio / IntelliJ but you have to compile Dart plugin yourself with a little modification: comment this line
    startedServer.completion_setSubscriptions(ImmutableList.of(CompletionService.AVAILABLE_SUGGESTION_SETS));

[NikolnikovK]

Any follow up on this issue ?

[bwilkerson]

Yes, we are actively discussing how best to address this situation and I think we're getting close to having a plan. I don't know how long it will take to implement, but it should get better eventually.