Skip to content

No completions returned on Windows using last night's build or latest flutter #32186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DanTup opened this issue Feb 15, 2018 · 9 comments
Closed
Labels
devexp-completion Issues with the analysis server's code completion feature legacy-area-analyzer Use area-devexp instead. os-windows

Comments

@DanTup
Copy link
Collaborator

DanTup commented Feb 15, 2018

I was trying to test something with the nightly build of the SDK (from http://gsdview.appspot.com/dart-archive/channels/be/raw/latest/sdk/) earlier and I was getting no completions back on Windows. Tried same thing on my Mac and it was fine.

Just now, noticed the same thing with latest flutter Code.

Log of me trying to complete on print:

analyzer.txt

@bwilkerson

@DanTup DanTup changed the title No completions returned on Windows using last night's build/flutter No completions returned on Windows using last night's build or latest flutter Feb 15, 2018
@devoncarew devoncarew added the legacy-area-analyzer Use area-devexp instead. label Feb 15, 2018
@devoncarew
Copy link
Member

It would be awesome to bisect this; I understand you can't build on windows just yet.

@devoncarew devoncarew added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Feb 15, 2018
@devoncarew
Copy link
Member

also /cc @scheglov

@DanTup
Copy link
Collaborator Author

DanTup commented Feb 15, 2018

Actually, the problem I had running from source on Windows a few days ago was the same as this - I was getting no results back. I figured I hadn't set things up properly (I had errors about my VS install during gclient sync). Now it's looking like it was probably the same issue.

@devoncarew
Copy link
Member

It's not clear to me how the analysis server's integration tests for code completion could pass on the windows bots w/ this issue.

@DanTup
Copy link
Collaborator Author

DanTup commented Feb 15, 2018

I thought that too; so I'm hoping this is just something really wonky at my end, but since I've seen it with last nights and latest flutter but as soon as I switch to another it works, I'm not so sure. If someone on Windows can pull latest Flutter and test it there, that should help.

@DanTup
Copy link
Collaborator Author

DanTup commented Feb 15, 2018

@devoncarew @bwilkerson

Oh man, I just tested this from source with/without my Windows drive letter change and it looks bad. Completions without it, no results with it. I don't know why this isn't breaking tests (or why it fixes the analysis issues yet breaks completion).

I've got to run shortly, someone can revert my change and I can dig into it next week.

The PR that did it -> #32133

@devoncarew
Copy link
Member

No worries; let's plan on reverting, and dig into the failure later.

@scheglov
Copy link
Contributor

scheglov commented Feb 15, 2018

@devoncarew devoncarew added devexp-completion Issues with the analysis server's code completion feature os-windows and removed P1 A high priority bug; for example, a single project is unusable or has many test failures labels Feb 15, 2018
dart-bot pushed a commit that referenced this issue Feb 15, 2018
This reverts commit 56acaee.

See #32186

[email protected], [email protected]

Change-Id: I76c673758e4b9acd22044985b4054b5504f4a205
Reviewed-on: https://dart-review.googlesource.com/41902
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
@DanTup
Copy link
Collaborator Author

DanTup commented Feb 20, 2018

Closing this as it was fixed with the revert in d9a44c9. The original bug is re-opened and I'll investigate that again once I've got all the tests sorted on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devexp-completion Issues with the analysis server's code completion feature legacy-area-analyzer Use area-devexp instead. os-windows
Projects
None yet
Development

No branches or pull requests

3 participants