-
Notifications
You must be signed in to change notification settings - Fork 1.7k
No completions returned on Windows using last night's build or latest flutter #32186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It would be awesome to bisect this; I understand you can't build on windows just yet. |
also /cc @scheglov |
Actually, the problem I had running from source on Windows a few days ago was the same as this - I was getting no results back. I figured I hadn't set things up properly (I had errors about my VS install during |
It's not clear to me how the analysis server's integration tests for code completion could pass on the windows bots w/ this issue. |
I thought that too; so I'm hoping this is just something really wonky at my end, but since I've seen it with last nights and latest flutter but as soon as I switch to another it works, I'm not so sure. If someone on Windows can pull latest Flutter and test it there, that should help. |
Oh man, I just tested this from source with/without my Windows drive letter change and it looks bad. Completions without it, no results with it. I don't know why this isn't breaking tests (or why it fixes the analysis issues yet breaks completion). I've got to run shortly, someone can revert my change and I can dig into it next week. The PR that did it -> #32133 |
No worries; let's plan on reverting, and dig into the failure later. |
https://dart-review.googlesource.com/c/sdk/+/41902 has reverted it. |
This reverts commit 56acaee. See #32186 [email protected], [email protected] Change-Id: I76c673758e4b9acd22044985b4054b5504f4a205 Reviewed-on: https://dart-review.googlesource.com/41902 Commit-Queue: Konstantin Shcheglov <[email protected]> Reviewed-by: Brian Wilkerson <[email protected]>
Closing this as it was fixed with the revert in d9a44c9. The original bug is re-opened and I'll investigate that again once I've got all the tests sorted on Windows. |
I was trying to test something with the nightly build of the SDK (from http://gsdview.appspot.com/dart-archive/channels/be/raw/latest/sdk/) earlier and I was getting no completions back on Windows. Tried same thing on my Mac and it was fine.
Just now, noticed the same thing with latest flutter Code.
Log of me trying to complete on
print
:analyzer.txt
@bwilkerson
The text was updated successfully, but these errors were encountered: