package-root bug in dart2js: import a file with a 'package:' and a relative URL

[sigmundch]

When importing a file with 'package:' the file should resolve to the same library as if it was imported with a relative URL.

Example to repro this error:
./out/Release_ia32/frog/bin/frog --package-root=./ a.dart

Where a.dart is:

library("a");

import('b.dart', prefix: 'b1');

import('b.dart', prefix: 'b2');

import('package:b.dart', prefix: 'b3');

main() {
  print("${b1.x === b2.x} ${b1.x === b3.x}");
}

And b.dart is:

library("b");

class X {
  const X();
}
final X x = const X();

[sigmundch]

On that example: the program should print "true true", but prints "true false"

[iposva-google]

See discussion in issue #3148.

[sigmundch]

Following up after the discussion in issue #3148.

Running:
./out/Release_ia32/frog/bin/frog --package-root=./ a.dart

should print 'true false' as it does today, but
./out/Release_ia32/frog/bin/frog --package-root=./ 'package:a.dart'

should print 'true true'.

Equivalently if we add a third file 'c.dart' with this contents:

#library('c');
#import('package:a.dart');

Then I expect to have 'true true' when I call
./out/Release_ia32/frog/bin/frog --package-root=./ c.dart

[anders-sandholm]

Removed Area-Frog label.
Added Area-Dart2JS, OldAreaFrog labels.

[anders-sandholm]

Removed OldAreaFrog label.
Added FromAreaFrog label.

[anders-sandholm]

Verified that dart2js has the same behavior as described in the issue for Frog.

---

Removed FromAreaFrog label.
Changed the title to: "package-root bug in dart2js: import a file with a 'package:' and a relative URL".

[sigmundch]

Removed Priority-Medium label.
Added Priority-High label.

[kasperl]

Nicolas, do you have time to take a look at this?

---

Set owner to [email protected].
Added Accepted label.

[peter-ahe-google]

CL here: https://chromiumcodereview.appspot.com/10533123/

---

Set owner to @peter-ahe-google.
Added Started label.

[peter-ahe-google]

Fixed in r8606

---

Added Fixed label.