Skip to content

File results with multiple matches should have disambiguating labels #3066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pq opened this issue May 15, 2012 · 1 comment
Closed

File results with multiple matches should have disambiguating labels #3066

pq opened this issue May 15, 2012 · 1 comment
Assignees
@pq

Comments

@pq
Copy link
Member

pq commented May 15, 2012

For example, assuming Jane has 2 files Foo.dart, the current behavior shows them like this:

Bar.dart
Foo.dart
Foo.dart

Lame.

A proposed improvement would do as spotlight does:

Bar.dart
Foo.dart - dir1
Foo.dart - dir2

where dir1 and dir2 are the containing folders (and are rendered in a lighter color than Foo.dart). Notice that Bar.dart needs no disambiguation so it gets none.
@pq
Copy link
Member Author

pq commented May 16, 2012

Fixed.

http://codereview.chromium.org/10382207/

Added Fixed label.

@pq pq self-assigned this May 16, 2012
copybara-service bot pushed a commit that referenced this issue Jul 5, 2022
Roll Dart Documentation Generator from 900432d8cb1e to 21f9341eb662 (…
1b8cae1 
…4 revisions)

https://dart.googlesource.com/dartdoc/+log/900432d8cb1e..21f9341eb662

2022-07-05 [email protected] Switch to analyzer's updateAnalysisOptions2 (#3068)
2022-07-05 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 1.1.1 to 1.1.2 (#3067)
2022-07-05 [email protected] bumped analyzer version to 4.0.0 (#3033)
2022-07-05 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.1.14 to 2.1.15 (#3066)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-doc-dart-sdk
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Dart Documentation Generator: https://github.com/dart-lang/dartdoc/issues
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: [email protected]
Change-Id: I6abe8e224af5682f96a7624e5b24a4921bf6c890
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250701
Commit-Queue: Kevin Moore <[email protected]>
Commit-Queue: DEPS Autoroller <[email protected]>
Reviewed-by: Kevin Moore <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pq