Skip to content

Text search is unavailable until after type cache warm-up #3056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pq opened this issue May 14, 2012 · 2 comments
Closed

Text search is unavailable until after type cache warm-up #3056

pq opened this issue May 14, 2012 · 2 comments
Assignees
Milestone

Comments

@pq
Copy link
Member

pq commented May 14, 2012

Our list of search proposals is built synchronously and the first call to the SearchEngine to retrieve types is expensive and blocks rendering of the proposal list until it returns. This makes for a crummy user experience.

A few things to consider:

  1. can we warm up the type cache so that this first call is cheaper?
  2. how hard would it be to make search proposal rendering more asynchronous?
  3. if we can make it asynchronous how can we communicate to the user that the results are (as of yet) incomplete?
  4. in general, how best can we communicate to the user when the search "index" is being "built" (which is to say, when search results will be reliable) [1](Note that in some senses this transcends searchbox searches since analysis state impacts code completion, problem markers, etc.)

[1] OS X spotlight presents a message in their pull-down that says something like this: "Search results may not include all matches until Spotlight finishes indexing the contents of your computer." In addition, they present a progress bar with an estimate ("Indexing my-computer -- About 35 minutes remaining").

@pq
Copy link
Member Author

pq commented Jun 4, 2012

Added this to the M1 milestone.

@pq
Copy link
Member Author

pq commented Jun 8, 2012

Addressed w/: https://chromiumcodereview.appspot.com/10510012/


Added Fixed label.

@pq pq self-assigned this Jun 8, 2012
@pq pq added this to the M1 milestone Jun 8, 2012
copybara-service bot pushed a commit that referenced this issue Jun 8, 2022
…3 revisions)

https://dart.googlesource.com/dartdoc/+log/f5bcc4bd46f4..b61647bc3833

2022-06-08 [email protected] Pin github actions to a hash (#3056)
2022-06-06 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 1.1.0 to 1.1.1 (#3059)
2022-06-06 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.1.11 to 2.1.12 (#3057)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-doc-dart-sdk
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Dart Documentation Generator: https://github.com/dart-lang/dartdoc/issues
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: [email protected]
Change-Id: Ia70e7e622ec520a5f8f19d3bfc51608c8d6f5c70
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247469
Reviewed-by: Devon Carew <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant