Some operations on HashSet<double> is ~5000 times slower than HashSet<int> #2859
Labels
closed-duplicate
Closed in favor of an existing report
Comments
|
This comment was originally written by @mdakin Oh, I just realized hash value for doubles is always 0, so that causes the problem. Should I close the bug and reopen another, or this maybe this is a feature? |
|
This comment was originally written by @mdakin I created http://code.google.com/p/dart/issues/detail?id=2884 for better hashCode for doubles. This bug can be closed. |
dart-bot
pushed a commit
that referenced
this issue
Mar 23, 2021
New commits included: ``` > git log --format="%C(auto) %h %s" 0e657414a472e74ca5dd76ae0db50cc060251dec..255a3091fc278b04be74d246a3bec8743ef4d0b7 255a3091 Vendor package:tar and package:chunked_stream (#2932) 86bf8b20 Handle relative git-url-paths correctly when --directory (#2919) 3716a681 Let `pub add` fail if extra arguments are passed (#2927) a03ac729 Minor cleanup to reduce risk of using path.current (#2924) e87b7b66 Added null check for name in UserInfo class (#2918) 056a8c9a pub deps --json (#2896) 53a69e27 Fix .packages entries of relative path deps when using --directory (#2916) d6308efc pub upgrade command shows count of discontinued packages (#2908) 51744805 Upgrade to the null safe versions of all dependencies (#2913) e0d538c7 Introduce .pubignore (#2787) 79f3a8b9 pub outdated: added clear message when no outdated packages. (#2898) 22463872 `cache clean` (#2904) 11e7b2ce `publish --dry-run` informs that the server might do more checks (#2883) b6977d50 Remove untrue assert (#2884) 35841f8d Merge branch 'cherry_picks_for_2_12' 0db3255b Don't fail on failed status listing (#2877) 53e8ecca Don't allow outdated taking arguments (#2872) e83a1dc1 Enable asserts when testing pub (#2754) 178f2edb Add --directory option (#2876) 5aadb70e Don't fail on failed status listing (#2877) 4bf8a927 Remove unused field (#2878) 73ad5426 Don't allow outdated taking arguments (#2872) 9a70949e Use Dart library to read and write tar files (#2817) 2f74230c Do not recommend decativating packages (#2871) b1697a27 Use full error message string in CommandResolutionFailedException (#2870) 16a6210d Upgrade `downgrade --help`: `downgrade` actually updates `pubspec.lock` (#2859) 6e240ea9 Use cached version listings as heuristic when prefetching (#2851) 58152f7c Allow trailing slash in PUB_HOSTED_URL (#2856) b1bf9a33 Handle poor package-listing responses robustly. (#2847) d941bd24 Fix request metadata when overriding dependencyType (#2848) ``` Change-Id: Id6ed5698330fc0cdb507e024eabc34f925ca9208 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192304 Commit-Queue: Sigurd Meldgaard <[email protected]> Reviewed-by: Jonas Jensen <[email protected]>
dart-bot
pushed a commit
that referenced
this issue
Mar 24, 2021
This reverts commit 633d4ac. Reason for revert: breaks dependency resolution in some cases. Original change's description: > Bump pub > > New commits included: > ``` > > git log --format="%C(auto) %h %s" 0e657414a472e74ca5dd76ae0db50cc060251dec..255a3091fc278b04be74d246a3bec8743ef4d0b7 > 255a3091 Vendor package:tar and package:chunked_stream (#2932) > 86bf8b20 Handle relative git-url-paths correctly when --directory (#2919) > 3716a681 Let `pub add` fail if extra arguments are passed (#2927) > a03ac729 Minor cleanup to reduce risk of using path.current (#2924) > e87b7b66 Added null check for name in UserInfo class (#2918) > 056a8c9a pub deps --json (#2896) > 53a69e27 Fix .packages entries of relative path deps when using --directory (#2916) > d6308efc pub upgrade command shows count of discontinued packages (#2908) > 51744805 Upgrade to the null safe versions of all dependencies (#2913) > e0d538c7 Introduce .pubignore (#2787) > 79f3a8b9 pub outdated: added clear message when no outdated packages. (#2898) > 22463872 `cache clean` (#2904) > 11e7b2ce `publish --dry-run` informs that the server might do more checks (#2883) > b6977d50 Remove untrue assert (#2884) > 35841f8d Merge branch 'cherry_picks_for_2_12' > 0db3255b Don't fail on failed status listing (#2877) > 53e8ecca Don't allow outdated taking arguments (#2872) > e83a1dc1 Enable asserts when testing pub (#2754) > 178f2edb Add --directory option (#2876) > 5aadb70e Don't fail on failed status listing (#2877) > 4bf8a927 Remove unused field (#2878) > 73ad5426 Don't allow outdated taking arguments (#2872) > 9a70949e Use Dart library to read and write tar files (#2817) > 2f74230c Do not recommend decativating packages (#2871) > b1697a27 Use full error message string in CommandResolutionFailedException (#2870) > 16a6210d Upgrade `downgrade --help`: `downgrade` actually updates `pubspec.lock` (#2859) > 6e240ea9 Use cached version listings as heuristic when prefetching (#2851) > 58152f7c Allow trailing slash in PUB_HOSTED_URL (#2856) > b1bf9a33 Handle poor package-listing responses robustly. (#2847) > d941bd24 Fix request metadata when overriding dependencyType (#2848) > ``` > > Change-Id: Id6ed5698330fc0cdb507e024eabc34f925ca9208 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192304 > Commit-Queue: Sigurd Meldgaard <[email protected]> > Reviewed-by: Jonas Jensen <[email protected]> [email protected],[email protected] Change-Id: I364a26468a36438bbbc887e613241030decef4d3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192748 Reviewed-by: Alexander Thomas <[email protected]> Commit-Queue: Alexander Thomas <[email protected]>
dart-bot
pushed a commit
that referenced
this issue
May 11, 2021
New commits include: ``` $ git log --format="%C(auto) %h %s" 0e657414a472e74ca5dd76ae0db50cc060251dec..00c00e8adf9706bebe8f94483b7663c5f36f59d2 00c00e8a Vendor tar (#2987) 291705ca Being gradual migration to null-safety (#2988) c5f52a37 Fix CI (#2989) 74040a45 Update to analyzer 1.5.0, migrate from deprecated AnalysisSession.getParsedUnit() (#2975) ce951d70 Fix dry-run tests for publishing by ensuring there is a server to reject requests (#2978) 018c9650 Update LICENSE (#2944) 2614f15c Revert "Vendor package:tar and package:chunked_stream (#2932)" (#2940) 12d9f457 Handle package:tar cancellations 255a3091 Vendor package:tar and package:chunked_stream (#2932) 86bf8b20 Handle relative git-url-paths correctly when --directory (#2919) 3716a681 Let `pub add` fail if extra arguments are passed (#2927) a03ac729 Minor cleanup to reduce risk of using path.current (#2924) e87b7b66 Added null check for name in UserInfo class (#2918) 056a8c9a pub deps --json (#2896) 53a69e27 Fix .packages entries of relative path deps when using --directory (#2916) d6308efc pub upgrade command shows count of discontinued packages (#2908) 51744805 Upgrade to the null safe versions of all dependencies (#2913) e0d538c7 Introduce .pubignore (#2787) 79f3a8b9 pub outdated: added clear message when no outdated packages. (#2898) 22463872 `cache clean` (#2904) 11e7b2ce `publish --dry-run` informs that the server might do more checks (#2883) b6977d50 Remove untrue assert (#2884) 35841f8d Merge branch 'cherry_picks_for_2_12' 0db3255b Don't fail on failed status listing (#2877) 53e8ecca Don't allow outdated taking arguments (#2872) e83a1dc1 Enable asserts when testing pub (#2754) 178f2edb Add --directory option (#2876) 5aadb70e Don't fail on failed status listing (#2877) 4bf8a927 Remove unused field (#2878) 73ad5426 Don't allow outdated taking arguments (#2872) 9a70949e Use Dart library to read and write tar files (#2817) 2f74230c Do not recommend decativating packages (#2871) b1697a27 Use full error message string in CommandResolutionFailedException (#2870) 16a6210d Upgrade `downgrade --help`: `downgrade` actually updates `pubspec.lock` (#2859) 6e240ea9 Use cached version listings as heuristic when prefetching (#2851) 58152f7c Allow trailing slash in PUB_HOSTED_URL (#2856) b1bf9a33 Handle poor package-listing responses robustly. (#2847) d941bd24 Fix request metadata when overriding dependencyType (#2848) ``` Change-Id: Id7cc4c09e74c02a92bcafe1a9d9bab9431900540 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/199040 Reviewed-by: Alexander Thomas <[email protected]> Commit-Queue: Jonas Jensen <[email protected]>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue was originally filed by @mdakin
What steps will reproduce the problem?
1.Run the code in server mode: https://gist.github.com/2575116
On my machine, output is:
ints
Add: 12 ms.
Contains: 3 ms.
Iterate: 5 ms.
Remove: 5 ms.
Sort list: 44 ms.
doubles
Add: 71282 ms.
Contains: 40625 ms.
Iterate: 5 ms.
Remove: 87247 ms.
Sort list: 65 ms.
What is the expected output? What do you see instead?
HashSet<double> and HashSet<int> should have a similar performance.
What version of the product are you using? On what operating system?
Mac, Linux. Dart SDK version 7149, Dartium version
Please provide any additional information below.
I checked the performance of hashCode() method on ints and doubles, they are similar (double is slightly slower, as expected).
The text was updated successfully, but these errors were encountered: