Skip to content

dartdevc should use now SDK-shipped js and summary files #27607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kevmoo opened this issue Oct 18, 2016 · 10 comments
Closed

dartdevc should use now SDK-shipped js and summary files #27607

kevmoo opened this issue Oct 18, 2016 · 10 comments
Assignees
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dev-compiler
Milestone

Comments

@kevmoo
Copy link
Member

kevmoo commented Oct 18, 2016

Use the files now in the SDK release.
Couldn't we remove/hide these options? Or at least explain that they will have good defaults

--dart-sdk                     Dart SDK Path
--dart-sdk-summary             Dart SDK Summary Path
@kevmoo kevmoo added this to the 1.21 milestone Oct 18, 2016
@jmesserly
Copy link

jmesserly commented Oct 18, 2016

yes definitely. --dart-sdk-summary should be removedhidden (edit: this flag turns out to be used by DDC's tests). --dart-sdk should be made internal to the API or hidden, it only exists for us to build the SDK summary.

@vsmenon
Copy link
Member

vsmenon commented Oct 18, 2016

Right now, it appears that the dartdevc snapshot in the built SDK is using the analyzer's summary by default. It could instead use the ones shipped under dart-sdk/lib/_internal/dev_compiler.

Note, we don't use dart_sdk.js to compile. But, if someone wants to run with the DDC SDK, they'd need to also use one under dart-sdk/lib/_internal/dev_compiler.

@jmesserly
Copy link

yeah. we should probably move that out of _internal, since folks need to be able to include it.

@kevmoo
Copy link
Member Author

kevmoo commented Oct 18, 2016

I believe @stereotype441 was working around this internally, too – would be good to get this straightened out

@jmesserly
Copy link

@kevmoo I think @vsmenon is looking into this but let me know if I can help

@vsmenon
Copy link
Member

vsmenon commented Oct 27, 2016

Any thoughts on where to move it? E.g.,

dart-sdk/lib/dev_compiler

@nex3
Copy link
Member

nex3 commented Oct 31, 2016

lib/ seems confusing to me, since that directory mostly contains Dart source files which are used in a very different way than this JS. Maybe dart-sdk/asset?

@jmesserly jmesserly added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Nov 1, 2016
@jmesserly
Copy link

jmesserly commented Nov 1, 2016

@vsmenon are you looking at this? If not I'll grab it tomorrow (or feel free to assign it to me). In addition to the JS files, we also need to include the corresponding SDK summaries.

@vsmenon
Copy link
Member

vsmenon commented Nov 1, 2016

@jmesserly it's all yours. :-)

@jmesserly
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dev-compiler
Projects
None yet
Development

No branches or pull requests

4 participants